Commit eabe6268 authored by Jérôme Lebel's avatar Jérôme Lebel Committed by Commit Bot

[iOS] Presenting sign-in promo in sheet style

Sign-in promo is always presented in sheet style (user sign-in or
sign-in promo). This patch doesn't change the first run, since it
is not presented.

Bug: 971989
Change-Id: I7923a728d6912013903b9fc71a24fef29f2b9b05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139764
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: default avatarNohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757080}
parent 8d9a3c32
...@@ -372,6 +372,7 @@ const CGFloat kFadeOutAnimationDuration = 0.16f; ...@@ -372,6 +372,7 @@ const CGFloat kFadeOutAnimationDuration = 0.16f;
// controller. First run requires an additional transitional fade animation when // controller. First run requires an additional transitional fade animation when
// presenting this view. // presenting this view.
- (void)presentUserSigninViewController { - (void)presentUserSigninViewController {
self.viewController.modalPresentationStyle = UIModalPresentationFormSheet;
switch (self.signinIntent) { switch (self.signinIntent) {
case UserSigninIntentFirstRun: { case UserSigninIntentFirstRun: {
// Displays the sign-in screen with transitions specific to first-run. // Displays the sign-in screen with transitions specific to first-run.
...@@ -413,7 +414,7 @@ const CGFloat kFadeOutAnimationDuration = 0.16f; ...@@ -413,7 +414,7 @@ const CGFloat kFadeOutAnimationDuration = 0.16f;
} }
case UserSigninIntentSignin: { case UserSigninIntentSignin: {
DCHECK(self.baseViewController); DCHECK(self.baseViewController);
self.viewController.modalPresentationStyle = UIModalPresentationFormSheet;
[self.baseViewController presentViewController:self.viewController [self.baseViewController presentViewController:self.viewController
animated:YES animated:YES
completion:nil]; completion:nil];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment