Commit eafb6fef authored by Alexey Baskakov's avatar Alexey Baskakov Committed by Chromium LUCI CQ

Revert "Quick Answers: Add page size options for Search request"

This reverts commit 8144dae3.

Reason for revert: breaks unit tests in this build:
https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10489/overview

Original change's description:
> Quick Answers: Add page size options for Search request
>
> Since we only use the first result from search request, set the page
> size to 1 to reduce the delay.
>
> Bug: b/173239982
> Test: None
> Change-Id: Ib2abd92e23b430b837f0556c31bcc0d17873256e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574072
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Commit-Queue: Yue Li <updowndota@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#833940}

TBR=xiyuan@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jeroendh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/173239982
Change-Id: I4348e98fcc27160c01ecf4a9c048844861f5c15c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576659Reviewed-by: default avatarAlexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834097}
parent aae9d035
......@@ -30,9 +30,6 @@ using network::mojom::URLLoaderFactory;
// "client_id": {
// "client_type": "EXPERIMENTAL"
// }
// "options": {
// "page_size": "1"
// }
// }
//
// Which is:
......@@ -41,17 +38,12 @@ using network::mojom::URLLoaderFactory;
// "raw_query": STRING
// "client_id": DICT
// "client_type": STRING
// "options": DICT
// "page_size": STRING
constexpr base::StringPiece kQueryKey = "query";
constexpr base::StringPiece kRawQueryKey = "rawQuery";
constexpr base::StringPiece kClientTypeKey = "clientType";
constexpr base::StringPiece kClientIdKey = "clientId";
constexpr base::StringPiece kClientType = "QUICK_ANSWERS_CROS";
constexpr base::StringPiece kPageSizeKey = "pageSize";
constexpr base::StringPiece kOptionsKey = "options";
constexpr base::StringPiece kPageSize = "1";
std::string BuildSearchRequestPayload(const std::string& selected_text) {
Value payload(Value::Type::DICTIONARY);
......@@ -65,10 +57,6 @@ std::string BuildSearchRequestPayload(const std::string& selected_text) {
client_id.SetKey(kClientTypeKey, Value(kClientType));
payload.SetKey(kClientIdKey, std::move(client_id));
Value options(Value::Type::DICTIONARY);
options.SetKey(kPageSizeKey, Value(kPageSize));
payload.SetKey(kOptionsKey, std::move(options));
std::string request_payload_str;
base::JSONWriter::Write(payload, &request_payload_str);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment