Commit eb00d8dd authored by Regan Hsu's avatar Regan Hsu Committed by Commit Bot

[CrOS Settings] Clicking the row should also toggle reverse scrolling.

The CL that previously addressed this problem only allowed pressing
the toggle button to enable/disable reverse scrolling, when the entire
row can be clicked in order to enable/disable reverse scrolling
(except for the learn more link).

Fixed: 1109966
Change-Id: Ica6eb360f2ac22770ff130f57b4cae5e58df2000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339603Reviewed-by: default avatarRegan Hsu <hsuregan@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795198}
parent 1d55648f
...@@ -112,6 +112,6 @@ Polymer({ ...@@ -112,6 +112,6 @@ Polymer({
onReverseScrollRowClicked_: function() { onReverseScrollRowClicked_: function() {
this.setPrefValue( this.setPrefValue(
'settings.touchpad.natural_scroll', 'settings.touchpad.natural_scroll',
this.getPref('settings.touchpad.natural_scroll').value); !this.getPref('settings.touchpad.natural_scroll').value);
}, },
}); });
...@@ -687,7 +687,7 @@ cr.define('device_page_tests', function() { ...@@ -687,7 +687,7 @@ cr.define('device_page_tests', function() {
// Check specifically clicking the row changes pref. // Check specifically clicking the row changes pref.
const reverseScrollSettings = pointersPage.$$('#reverseScrollRow'); const reverseScrollSettings = pointersPage.$$('#reverseScrollRow');
reverseScrollToggle.click(); reverseScrollSettings.click();
expectReverseScrollValue(pointersPage, true); expectReverseScrollValue(pointersPage, true);
devicePage.set('prefs.settings.touchpad.natural_scroll.value', false); devicePage.set('prefs.settings.touchpad.natural_scroll.value', false);
expectReverseScrollValue(pointersPage, false); expectReverseScrollValue(pointersPage, false);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment