Commit eb0ce162 authored by John Budorick's avatar John Budorick Committed by Commit Bot

Revert "Reland "Android: turning on bytecode checker""

This reverts commit ba0225d1.

Reason for revert: breaks internal compilation; see e.g. http://shortn/_9928H1Hk0R

Original change's description:
> Reland "Android: turning on bytecode checker"
> 
> This is a reland of 0301a791
> 
> I don't think this would have caused a runtime chromeos error, since it's
> a build time android change. If it pops up again that I broke the test,
> I will investigate further.
> 
> TBR=retry
> 
> Original change's description:
> > Android: turning on bytecode checker
> >
> > This arg was defaulting to false when it should have defaulted to true.
> >
> > TBR=turning off bytecode checks for certain dirs
> >
> > Bug: 874854
> > Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8
> > Reviewed-on: https://chromium-review.googlesource.com/c/1309973
> > Commit-Queue: Sam Maier <smaier@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#605068}
> 
> Bug: 874854
> Change-Id: Idc95750d4465ca53b72db26a98ce74724fe21968
> Reviewed-on: https://chromium-review.googlesource.com/c/1318071
> Reviewed-by: Sam Maier <smaier@chromium.org>
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605347}

TBR=agrieve@chromium.org,smaier@chromium.org

Change-Id: I4bb41ab999431fd2df511838d10db598cd5c0a87
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 874854
Reviewed-on: https://chromium-review.googlesource.com/c/1319333Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605586}
parent 077f8178
......@@ -1418,7 +1418,7 @@ if (enable_java_templates) {
_enable_bytecode_rewriter =
_enable_assert || _enable_custom_resources || _enable_thread_annotations
_is_prebuilt = defined(invoker.is_prebuilt) && invoker.is_prebuilt
_enable_bytecode_checks = !defined(invoker.enable_bytecode_checks) ||
_enable_bytecode_checks = defined(invoker.enable_bytecode_checks) &&
invoker.enable_bytecode_checks
# Release builds don't have asserts enabled, so they often will not run the
......
......@@ -127,7 +127,6 @@ mojom("interfaces") {
]
deps = [
"//mojo/public/mojom/base",
"//services/network/public/mojom",
]
}
......@@ -450,7 +450,6 @@ android_library("content_javatests") {
"//third_party/android_support_test_runner:runner_java",
"//third_party/blink/public:android_mojo_bindings_java",
"//third_party/blink/public:blink_headers_java",
"//third_party/hamcrest:hamcrest_java",
"//third_party/jsr-305:jsr_305_javalib",
"//third_party/junit",
"//ui/android:ui_java",
......
......@@ -7,20 +7,17 @@ import("//build/config/android/rules.gni")
java_prebuilt("byte_buddy_java") {
supports_android = true
testonly = true
enable_bytecode_checks = false
jar_path = "lib/byte-buddy.jar"
}
java_prebuilt("byte_buddy_agent_java") {
supports_android = true
testonly = true
enable_bytecode_checks = false
jar_path = "lib/byte-buddy-agent.jar"
}
android_java_prebuilt("byte_buddy_android_java") {
testonly = true
enable_bytecode_checks = false
deps = [
"//third_party/android_tools:dx_25_0_2_java",
]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment