[PwdCheckAndroid] Rename "Remove" list entry to "Delete password"

Change the entry title according to mocks.

Translation screenshot for
IDS_PASSWORD_CHECK_CREDENTIAL_MENU_ITEM_REMOVE_BUTTON_CAPTION:
https://storage.cloud.google.com/chromium-translation-screenshots/4498e485f2a7952b74d25537b1578da091430bbb

Bug: 1106726, 1092444
Change-Id: Ic902a2f7f5a6bb6eada949beed220a7155b6cf78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362935Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799652}

chrome/browser/password_check/android/internal/java/src/org/chromium/chrome/browser/password_check/PasswordCheckViewBinder.java

@@ -454,15 +454,16 @@ class PasswordCheckViewBinder {
                 R.string.password_check_credential_menu_item_view_button_caption, 0, 0, true));
         menuItems.add(BasicListMenu.buildMenuListItem(
                 R.string.password_check_credential_menu_item_edit_button_caption, 0, 0, true));
-        menuItems.add(
-                BasicListMenu.buildMenuListItem(org.chromium.chrome.R.string.remove, 0, 0, true));
+        menuItems.add(BasicListMenu.buildMenuListItem(
+                R.string.password_check_credential_menu_item_remove_button_caption, 0, 0, true));
         ListMenu.Delegate delegate = (listModel) -> {
             int textId = listModel.get(ListMenuItemProperties.TITLE_ID);
             if (textId == R.string.password_check_credential_menu_item_view_button_caption) {
                 credentialHandler.onView(credential);
             } else if (textId == R.string.password_check_credential_menu_item_edit_button_caption) {
                 credentialHandler.onEdit(credential);
-            } else if (textId == org.chromium.chrome.R.string.remove) {
+            } else if (textId
+                    == R.string.password_check_credential_menu_item_remove_button_caption) {
                 credentialHandler.onRemove(credential);
             } else {
                 assert false : "No action defined for " + context.getString(textId);

chrome/browser/password_check/android/internal/java/strings/android_password_check_strings.grd

@@ -256,6 +256,9 @@
       <message name="IDS_PASSWORD_CHECK_CREDENTIAL_MENU_ITEM_VIEW_BUTTON_CAPTION" desc="Caption for the menu button allowing to view a compromised credential.">
         View password
       </message>
+      <message name="IDS_PASSWORD_CHECK_CREDENTIAL_MENU_ITEM_REMOVE_BUTTON_CAPTION" desc="Caption for the menu button allowing to remove a compromised credential.">
+        Delete password
+      </message>
 
       <!-- Password Check Toast strings -->
       <message name="IDS_PASSWORD_CHECK_SET_SCREEN_LOCK_TEXT" desc="Text prompting user to set a screen lock in order to view or edit their compromised passwords.">

chrome/browser/password_check/android/internal/java/strings/android_password_check_strings_grd/IDS_PASSWORD_CHECK_CREDENTIAL_MENU_ITEM_REMOVE_BUTTON_CAPTION.png.sha1

+4498e485f2a7952b74d25537b1578da091430bbb
\ No newline at end of file

chrome/browser/password_check/android/javatests/src/org/chromium/chrome/browser/password_check/PasswordCheckViewTest.java

@@ -519,7 +519,7 @@ public class PasswordCheckViewTest {
 
         TouchCommon.singleClickView(getCredentialMoreButtonAt(0));
 
-        onView(withText(org.chromium.chrome.R.string.remove))
+        onView(withText(R.string.password_check_credential_menu_item_remove_button_caption))
                 .inRoot(withDecorView(
                         not(is(mPasswordCheckView.getActivity().getWindow().getDecorView()))))
                 .perform(click());