Commit eb379645 authored by Manuel Rego Casasnovas's avatar Manuel Rego Casasnovas Committed by Chromium LUCI CQ

Avoid setting ImeTextSpan::underline_color on Windows

Like the rest of the platforms, this patch avoids
setting ImeTextSpan::underline_color to black color.
That way when the IME composition underline is painted it'll use
the text color and not be always black.

This makes the composition underline visible when you have
a dark background.

Bug: 1168012
Change-Id: Id4ec27ffe8e698ff41de93fc1260363f96e4aa3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637495Reviewed-by: default avatarYohei Yukawa <yukawa@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#845548}
parent 2409ec43
......@@ -77,7 +77,6 @@ void GetImeTextSpans(HIMC imm_context,
ui::ImeTextSpan ime_text_span;
ime_text_span.start_offset = clause_data[i];
ime_text_span.end_offset = clause_data[i + 1];
ime_text_span.underline_color = SK_ColorBLACK;
ime_text_span.thickness = ui::ImeTextSpan::Thickness::kThin;
ime_text_span.background_color = SK_ColorTRANSPARENT;
......
......@@ -1081,7 +1081,6 @@ bool TSFTextStore::GetCompositionStatus(
ImeTextSpan span;
span.start_offset = start_pos;
span.end_offset = start_pos + length;
span.underline_color = SK_ColorBLACK;
span.background_color = SK_ColorTRANSPARENT;
if (selection_.EqualsIgnoringDirection(
gfx::Range(span.start_offset, span.end_offset))) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment