Commit eb3fa55d authored by Julie Jeongeun Kim's avatar Julie Jeongeun Kim Committed by Commit Bot

Updates struct members from mojom files with pending_remote

This CL updates struct members from mojom files with pending_remote.
These members have been converted to new Mojo types already from C++
code. The reason that it worked with old Mojo types from mojom files
is that new Mojo types support compatibility.
So, this CL updates mojom files to generate new Mojo types.

Bug: 955171
Change-Id: Ic2bf1aeec232cf376862b97cbcdf06500f2ed0f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950049Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarKen Rockot <rockot@google.com>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#721791}
parent 48aaa193
......@@ -219,7 +219,8 @@ struct NetworkContextParams {
// Handles PAC script execution. If not populated, will attempt to use
// platform implementation to execute PAC scripts, if available (Only
// available on Windows and Mac).
proxy_resolver.mojom.ProxyResolverFactory? proxy_resolver_factory;
pending_remote<proxy_resolver.mojom.ProxyResolverFactory>?
proxy_resolver_factory;
// Retrieves the PAC script URL set via DHCP from the browser process. Only
// used if |proxy_resolver_factory| is set. Note: optional because some tests
......
......@@ -425,9 +425,9 @@ struct DataElement {
// TODO(richard.li): Deprecate this once NetworkService is fully shipped.
string? blob_uuid;
// For kDataPipe
network.mojom.DataPipeGetter? data_pipe_getter;
pending_remote<network.mojom.DataPipeGetter>? data_pipe_getter;
// For kChunkedDataPipe
network.mojom.ChunkedDataPipeGetter? chunked_data_pipe_getter;
pending_remote<network.mojom.ChunkedDataPipeGetter>? chunked_data_pipe_getter;
uint64 offset;
uint64 length;
......
......@@ -21,7 +21,7 @@ struct TrackedPersistentPrefStoreConfiguration {
string legacy_device_id;
string registry_seed;
mojo_base.mojom.String16 registry_path;
TrackedPreferenceValidationDelegate? validation_delegate;
pending_remote<TrackedPreferenceValidationDelegate>? validation_delegate;
pending_remote<ResetOnLoadObserver>? reset_on_load_observer;
};
......
......@@ -36,8 +36,8 @@ bool StructTraits<
return false;
}
out->type_ = data.type();
out->data_pipe_getter_ =
data.TakeDataPipeGetter<network::mojom::DataPipeGetterPtrInfo>();
out->data_pipe_getter_ = data.TakeDataPipeGetter<
mojo::PendingRemote<network::mojom::DataPipeGetter>>();
out->chunked_data_pipe_getter_ = data.TakeChunkedDataPipeGetter<
mojo::PendingRemote<network::mojom::ChunkedDataPipeGetter>>();
out->offset_ = data.offset();
......
......@@ -88,7 +88,7 @@ struct BackgroundFetchRegistrationData {
// The registration data and interface to make per registration calls.
struct BackgroundFetchRegistration {
BackgroundFetchRegistrationData registration_data;
BackgroundFetchRegistrationService registration_interface;
pending_remote<BackgroundFetchRegistrationService> registration_interface;
};
// This contains the data we need to record UKM metrics, that isn't needed for
......
......@@ -127,9 +127,9 @@ struct FetchAPIDataElement {
// For kBlob
string? blob_uuid;
// For kDataPipe
network.mojom.DataPipeGetter? data_pipe_getter;
pending_remote<network.mojom.DataPipeGetter>? data_pipe_getter;
// For kChunkedDataPipe
network.mojom.ChunkedDataPipeGetter? chunked_data_pipe_getter;
pending_remote<network.mojom.ChunkedDataPipeGetter>? chunked_data_pipe_getter;
uint64 offset;
uint64 length;
......
......@@ -114,8 +114,8 @@ struct PaymentRequestEventData {
array<PaymentShippingOption>? shipping_options;
// Handles events raised by the payment handler, such as "payment method
// changed" event. Null in content_browsertests.
PaymentHandlerHost? payment_handler_host;
// changed" event. NullRemote in content_browsertests.
pending_remote<PaymentHandlerHost>? payment_handler_host;
};
// This struct is provided to receive payment app response from render
......
......@@ -43,10 +43,10 @@ struct ServiceWorkerProviderInfoForStartWorker {
// |cache_storage| is an optional optimization so the service worker can use
// the Cache Storage API immediately without using InterfaceProvider. May be
// null for service workers created for update checks, as the optimization
// would be wasteful because these workers usually are aborted after the
// byte-to-byte update check before running.
CacheStorage? cache_storage;
// NullRemote for service workers created for update checks, as the
// optimization would be wasteful because these workers usually are aborted
// after the byte-to-byte update check before running.
pending_remote<CacheStorage>? cache_storage;
// TODO(crbug.com/990845): remove when no longer used.
pending_remote<service_manager.mojom.InterfaceProvider> interface_provider;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment