Commit eb40dba9 authored by Michał Pichliński's avatar Michał Pichliński Committed by Commit Bot

Set button label before showing the CollectedCookiesViews dialog.

After: https://chromium-review.googlesource.com/c/chromium/src/+/1853045
CollectedCookiesViews OK button label was "OK" instead of "Done", because
set_button_label was called after ShowWebModalDialogViews.

Change-Id: I3e53e4a5c1a663b49f960a8292998d26773d66c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878071
Commit-Queue: Michal Pichlinski <mpichlinski@opera.com>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710247}
parent 1874c334
...@@ -372,11 +372,11 @@ void CollectedCookiesViews::ViewHierarchyChanged( ...@@ -372,11 +372,11 @@ void CollectedCookiesViews::ViewHierarchyChanged(
CollectedCookiesViews::CollectedCookiesViews(content::WebContents* web_contents) CollectedCookiesViews::CollectedCookiesViews(content::WebContents* web_contents)
: web_contents_(web_contents) { : web_contents_(web_contents) {
constrained_window::ShowWebModalDialogViews(this, web_contents);
chrome::RecordDialogCreation(chrome::DialogIdentifier::COLLECTED_COOKIES);
DialogDelegate::set_button_label(ui::DIALOG_BUTTON_OK, DialogDelegate::set_button_label(ui::DIALOG_BUTTON_OK,
l10n_util::GetStringUTF16(IDS_DONE)); l10n_util::GetStringUTF16(IDS_DONE));
constrained_window::ShowWebModalDialogViews(this, web_contents);
chrome::RecordDialogCreation(chrome::DialogIdentifier::COLLECTED_COOKIES);
} }
void CollectedCookiesViews::Init() { void CollectedCookiesViews::Init() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment