Commit eb69c9a6 authored by Sam Maier's avatar Sam Maier Committed by Commit Bot

Added DoNotInline to AdditionalMenuItemProviderImpl

Using this + the DoNotInline fix (crrev.com/c/1730845), we go from 47 to 37
RetryVerifcationAtRuntime classes.

Bug: 965189
Change-Id: Ibbe9da08c0f0756fc9fc5c915c246e0352c32819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731771
Commit-Queue: Sam Maier <smaier@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: default avatarShimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683721}
parent dad4110d
...@@ -16,6 +16,7 @@ import android.view.View.OnClickListener; ...@@ -16,6 +16,7 @@ import android.view.View.OnClickListener;
import android.view.textclassifier.TextClassification; import android.view.textclassifier.TextClassification;
import org.chromium.base.Log; import org.chromium.base.Log;
import org.chromium.base.annotations.DoNotInline;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
...@@ -23,7 +24,10 @@ import java.util.Map; ...@@ -23,7 +24,10 @@ import java.util.Map;
// TODO(ctzsm): Add unit tests for this class once this is upstreamed. // TODO(ctzsm): Add unit tests for this class once this is upstreamed.
/** /**
* Implements AdditionalMenuItemProvider interface. * Implements AdditionalMenuItemProvider interface.
* We prevent inlinings since this uses a number of new Android APIs which would create verification
* errors (on older Android versions) which would require a slow re-verification at runtime.
*/ */
@DoNotInline
@SuppressLint("NewApi") @SuppressLint("NewApi")
public class AdditionalMenuItemProviderImpl implements AdditionalMenuItemProvider { public class AdditionalMenuItemProviderImpl implements AdditionalMenuItemProvider {
private static final String TAG = "MenuItemProvider"; private static final String TAG = "MenuItemProvider";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment