[layoutng] Inline trivial functions on NGLineBoxFragmentBuilder

And also mark Child as WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS

Change-Id: I6ba20fa19e13c9dfafda35b0825392cb28aa97f1
Reviewed-on: https://chromium-review.googlesource.com/c/1289700
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600945}

third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.cc

@@ -32,16 +32,6 @@ void NGLineBoxFragmentBuilder::Reset() {
   size_.inline_size = LayoutUnit();
 }
 
-LayoutUnit NGLineBoxFragmentBuilder::LineHeight() const {
-  return metrics_.LineHeight().ClampNegativeToZero();
-}
-
-const NGPhysicalFragment* NGLineBoxFragmentBuilder::Child::PhysicalFragment()
-    const {
-  return layout_result ? layout_result->PhysicalFragment().get()
-                       : fragment.get();
-}
-
 NGLineBoxFragmentBuilder::Child*
 NGLineBoxFragmentBuilder::ChildList::FirstInFlowChild() {
   for (auto& child : *this) {
@@ -61,16 +51,6 @@ NGLineBoxFragmentBuilder::ChildList::LastInFlowChild() {
   return nullptr;
 }
 
-void NGLineBoxFragmentBuilder::ChildList::InsertChild(
-    unsigned index,
-    scoped_refptr<NGLayoutResult> layout_result,
-    const NGLogicalOffset& offset,
-    LayoutUnit inline_size,
-    UBiDiLevel bidi_level) {
-  children_.insert(
-      index, Child{std::move(layout_result), offset, inline_size, bidi_level});
-}
-
 void NGLineBoxFragmentBuilder::ChildList::MoveInInlineDirection(
     LayoutUnit delta,
     unsigned start,
@@ -92,24 +72,6 @@ void NGLineBoxFragmentBuilder::ChildList::MoveInBlockDirection(LayoutUnit delta,
     children_[index].offset.block_offset += delta;
 }
 
-void NGLineBoxFragmentBuilder::SetMetrics(const NGLineHeightMetrics& metrics) {
-  metrics_ = metrics;
-}
-
-void NGLineBoxFragmentBuilder::SetBaseDirection(TextDirection direction) {
-  base_direction_ = direction;
-}
-
-void NGLineBoxFragmentBuilder::SwapPositionedFloats(
-    Vector<NGPositionedFloat>* positioned_floats) {
-  positioned_floats_.swap(*positioned_floats);
-}
-
-void NGLineBoxFragmentBuilder::SetBreakToken(
-    scoped_refptr<NGInlineBreakToken> break_token) {
-  break_token_ = std::move(break_token);
-}
-
 void NGLineBoxFragmentBuilder::AddChildren(ChildList& children) {
   offsets_.ReserveCapacity(children.size());
   children_.ReserveCapacity(children.size());

third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.h

@@ -6,10 +6,12 @@
 #define NGLineBoxFragmentBuilder_h
 
 #include "third_party/blink/renderer/core/layout/ng/geometry/ng_logical_offset.h"
+#include "third_party/blink/renderer/core/layout/ng/inline/ng_inline_break_token.h"
 #include "third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.h"
 #include "third_party/blink/renderer/core/layout/ng/inline/ng_line_height_metrics.h"
 #include "third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.h"
 #include "third_party/blink/renderer/core/layout/ng/ng_layout_result.h"
+#include "third_party/blink/renderer/core/layout/ng/ng_positioned_float.h"
 #include "third_party/blink/renderer/platform/wtf/allocator.h"
 
 namespace blink {
@@ -32,18 +34,26 @@ class CORE_EXPORT NGLineBoxFragmentBuilder final
 
   void Reset();
 
-  LayoutUnit LineHeight() const;
+  LayoutUnit LineHeight() const {
+    return metrics_.LineHeight().ClampNegativeToZero();
+  }
 
   const NGLineHeightMetrics& Metrics() const { return metrics_; }
-  void SetMetrics(const NGLineHeightMetrics&);
+  void SetMetrics(const NGLineHeightMetrics& metrics) { metrics_ = metrics; }
 
-  void SetBaseDirection(TextDirection);
+  void SetBaseDirection(TextDirection direction) {
+    base_direction_ = direction;
+  }
 
-  void SwapPositionedFloats(Vector<NGPositionedFloat>*);
+  void SwapPositionedFloats(Vector<NGPositionedFloat>* positioned_floats) {
+    positioned_floats_.swap(*positioned_floats);
+  }
 
   // Set the break token for the fragment to build.
   // A finished break token will be attached if not set.
-  void SetBreakToken(scoped_refptr<NGInlineBreakToken>);
+  void SetBreakToken(scoped_refptr<NGInlineBreakToken> break_token) {
+    break_token_ = std::move(break_token);
+  }
 
   // A data struct to keep NGLayoutResult or fragment until the box tree
   // structures and child offsets are finalized.
@@ -108,7 +118,10 @@ class CORE_EXPORT NGLineBoxFragmentBuilder final
     }
     bool HasBidiLevel() const { return bidi_level != 0xff; }
     bool IsPlaceholder() const { return !HasFragment() && !HasBidiLevel(); }
-    const NGPhysicalFragment* PhysicalFragment() const;
+    const NGPhysicalFragment* PhysicalFragment() const {
+      return layout_result ? layout_result->PhysicalFragment().get()
+                           : fragment.get();
+    }
   };
 
   // A vector of Child.
@@ -154,11 +167,14 @@ class CORE_EXPORT NGLineBoxFragmentBuilder final
     void AddChild(Args&&... args) {
       children_.emplace_back(std::forward<Args>(args)...);
     }
-    void InsertChild(unsigned,
-                     scoped_refptr<NGLayoutResult>,
-                     const NGLogicalOffset&,
+    void InsertChild(unsigned index,
+                     scoped_refptr<NGLayoutResult> layout_result,
+                     const NGLogicalOffset& offset,
                      LayoutUnit inline_size,
-                     UBiDiLevel);
+                     UBiDiLevel bidi_level) {
+      children_.insert(index, Child{std::move(layout_result), offset,
+                                    inline_size, bidi_level});
+    }
 
     void MoveInInlineDirection(LayoutUnit, unsigned start, unsigned end);
     void MoveInBlockDirection(LayoutUnit);
@@ -189,4 +205,7 @@ class CORE_EXPORT NGLineBoxFragmentBuilder final
 
 }  // namespace blink
 
+WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS(
+    blink::NGLineBoxFragmentBuilder::Child);
+
 #endif  // NGLineBoxFragmentBuilder