Commit eb701079 authored by Colin Blundell's avatar Colin Blundell Committed by Commit Bot

[Extensions] Remove API permission for deleted cast.streaming API

This API was removed in
https://chromium-review.googlesource.com/c/chromium/src/+/2225821. The
continued presence of this permissions check for the deleted API causes
a crash in debug builds. This CL removes the check, adjusts associated
unittests, and deprecates the permission.

Bug: 986981
Change-Id: I1b9a6596d8dd0af5a80f0fd2348b11569273cbaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428923Reviewed-by: default avatarmark a. foltz <mfoltz@chromium.org>
Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810515}
parent c9b3ad3e
...@@ -223,7 +223,6 @@ constexpr APIPermissionInfo::InitInfo permissions_to_register[] = { ...@@ -223,7 +223,6 @@ constexpr APIPermissionInfo::InitInfo permissions_to_register[] = {
// Platform-app permissions. // Platform-app permissions.
{APIPermission::kFileSystemProvider, "fileSystemProvider", {APIPermission::kFileSystemProvider, "fileSystemProvider",
APIPermissionInfo::kFlagDoesNotRequireManagedSessionFullLoginWarning}, APIPermissionInfo::kFlagDoesNotRequireManagedSessionFullLoginWarning},
{APIPermission::kCastStreaming, "cast.streaming"},
{APIPermission::kLauncherSearchProvider, "launcherSearchProvider"}, {APIPermission::kLauncherSearchProvider, "launcherSearchProvider"},
// Settings override permissions. // Settings override permissions.
......
...@@ -749,7 +749,6 @@ TEST(PermissionsTest, PermissionMessages) { ...@@ -749,7 +749,6 @@ TEST(PermissionsTest, PermissionMessages) {
skip.insert(APIPermission::kAppView); skip.insert(APIPermission::kAppView);
skip.insert(APIPermission::kAudio); skip.insert(APIPermission::kAudio);
skip.insert(APIPermission::kBrowsingData); skip.insert(APIPermission::kBrowsingData);
skip.insert(APIPermission::kCastStreaming);
skip.insert(APIPermission::kCommandsAccessibility); skip.insert(APIPermission::kCommandsAccessibility);
skip.insert(APIPermission::kContextMenus); skip.insert(APIPermission::kContextMenus);
skip.insert(APIPermission::kCryptotokenPrivate); skip.insert(APIPermission::kCryptotokenPrivate);
...@@ -823,7 +822,6 @@ TEST(PermissionsTest, PermissionMessages) { ...@@ -823,7 +822,6 @@ TEST(PermissionsTest, PermissionMessages) {
skip.insert(APIPermission::kBookmarkManagerPrivate); skip.insert(APIPermission::kBookmarkManagerPrivate);
skip.insert(APIPermission::kBrailleDisplayPrivate); skip.insert(APIPermission::kBrailleDisplayPrivate);
skip.insert(APIPermission::kCast); skip.insert(APIPermission::kCast);
skip.insert(APIPermission::kCastStreaming);
skip.insert(APIPermission::kCecPrivate); skip.insert(APIPermission::kCecPrivate);
skip.insert(APIPermission::kChromeosInfoPrivate); skip.insert(APIPermission::kChromeosInfoPrivate);
skip.insert(APIPermission::kCloudPrintPrivate); skip.insert(APIPermission::kCloudPrintPrivate);
......
...@@ -66,7 +66,7 @@ class APIPermission { ...@@ -66,7 +66,7 @@ class APIPermission {
kBrowser = 22, kBrowser = 22,
kBrowsingData = 23, kBrowsingData = 23,
kCast = 24, kCast = 24,
kCastStreaming = 25, kDeleted_kCastStreaming = 25,
kChromeosInfoPrivate = 26, kChromeosInfoPrivate = 26,
kClipboardRead = 27, kClipboardRead = 27,
kClipboardWrite = 28, kClipboardWrite = 28,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment