Allow opting out of translucency manipulations with TWA splash screens

In WebAPKs, showing splash screens before browser launch is restricted to
Android N+ because of visual glitches on M-. The visual glitches occur
because translucency flipping doesn't play well with SurfaceViews.

To support this behavior in TWAs, we add a parameter allowing to opt-out
from translucency flipping.

Change-Id: Ibde67c49577afff32207c239b0736829b178520e

Bug: 989603
Change-Id: Ibde67c49577afff32207c239b0736829b178520e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744412Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686367}

chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/splashscreen/TwaSplashController.java

@@ -63,6 +63,11 @@ import androidx.browser.customtabs.TrustedWebUtils.SplashScreenParamKey;
  */
 public class TwaSplashController
         implements InflationObserver, SplashDelegate, SplashscreenObserver {
+
+    // TODO(pshmakov): move this to AndroidX.
+    private static final String KEY_SHOWN_IN_CLIENT =
+            "androidx.browser.trusted.KEY_SPLASH_SCREEN_SHOWN_IN_CLIENT";
+
     private final SplashController mSplashController;
     private final Activity mActivity;
     private final ActivityWindowAndroid mActivityWindowAndroid;
@@ -87,8 +92,9 @@ public class TwaSplashController
 
         long splashHideAnimationDurationMs = IntentUtils.safeGetInt(
                 getSplashScreenParamsFromIntent(), SplashScreenParamKey.FADE_OUT_DURATION_MS, 0);
+        boolean isWindowInitiallyTranslucent = mActivity instanceof TranslucentCustomTabActivity;
         mSplashController.setConfig(
-                this, true /* isWindowInitiallyTranslucent */, splashHideAnimationDurationMs);
+                this, isWindowInitiallyTranslucent, splashHideAnimationDurationMs);
 
         mSplashController.addObserver(this);
         lifecycleDispatcher.register(this);
@@ -193,7 +199,18 @@ public class TwaSplashController
     public static boolean handleIntent(Activity activity, Intent intent) {
         if (!intentIsForTwaWithSplashScreen(intent)) return false;
 
-        intent.setClassName(activity, TranslucentCustomTabActivity.class.getName());
+        Bundle params = IntentUtils.safeGetBundleExtra(
+                intent, TrustedWebUtils.EXTRA_SPLASH_SCREEN_PARAMS);
+        boolean shownInClient = IntentUtils.safeGetBoolean(params, KEY_SHOWN_IN_CLIENT, true);
+        // shownInClient is "true" by default for the following reasons:
+        // - For compatibility with older clients which don't use this bundle key.
+        // - Because getting "false" when it should be "true" leads to more severe visual glitches,
+        // than vice versa.
+        if (shownInClient) {
+            // If splash screen was shown in client, we must launch a translucent activity to
+            // ensure smooth transition.
+            intent.setClassName(activity, TranslucentCustomTabActivity.class.getName());
+        }
         intent.addFlags(Intent.FLAG_ACTIVITY_NO_ANIMATION);
         activity.startActivity(intent);
         activity.overridePendingTransition(0, 0);