Change Picture: Enable motion-stills by default.

This enables motion-stills by default and adds a feature flag for
turning it off.

Bug: 769140
Test: chrome --disable-features=ChangePictureVideoMode
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia2eef2d627914572d95c91d08e876e5e37d282e6
Reviewed-on: https://chromium-review.googlesource.com/842703
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526052}

chrome/browser/resources/chromeos/login/oobe_change_picture.js

@@ -68,7 +68,10 @@ Polymer({
      */
     cameraVideoModeEnabled: {
       type: Boolean,
-      value: false,
+      value: function() {
+        return loadTimeData.getBoolean('changePictureVideoModeEnabled');
+      },
+      readOnly: true,
     },
 
     /**

chrome/browser/resources/settings/people_page/change_picture.js

@@ -60,7 +60,10 @@ Polymer({
      */
     cameraVideoModeEnabled_: {
       type: Boolean,
-      value: false,
+      value: function() {
+        return loadTimeData.getBoolean('changePictureVideoModeEnabled');
+      },
+      readOnly: true,
     },
   },
 

chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

@@ -68,6 +68,7 @@
 #include "chrome/browser/ui/webui/test_files_request_filter.h"
 #include "chrome/browser/ui/webui/theme_source.h"
 #include "chrome/common/chrome_constants.h"
+#include "chrome/common/chrome_features.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
@@ -543,6 +544,9 @@ void OobeUI::GetLocalizedStrings(base::DictionaryValue* localized_strings) {
                                : "on");
   localized_strings->SetString(
       "showMdLogin", ash::switches::IsUsingWebUiLock() ? "off" : "on");
+  localized_strings->SetBoolean(
+      "changePictureVideoModeEnabled",
+      base::FeatureList::IsEnabled(features::kChangePictureVideoMode));
 }
 
 void OobeUI::AddWebUIHandler(std::unique_ptr<BaseWebUIHandler> handler) {

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -1514,6 +1514,10 @@ void AddPeopleStrings(content::WebUIDataSource* html_source) {
 
   html_source->AddBoolean("profileShortcutsEnabled",
                           ProfileShortcutManager::IsFeatureEnabled());
+
+  html_source->AddBoolean(
+      "changePictureVideoModeEnabled",
+      base::FeatureList::IsEnabled(features::kChangePictureVideoMode));
 }
 
 void AddPrintingStrings(content::WebUIDataSource* html_source) {

chrome/common/chrome_features.cc

@@ -148,6 +148,10 @@ const base::Feature kCaptureThumbnailDependingOnTransitionType{
 const base::Feature kCaptureThumbnailOnNavigatingAway{
     "CaptureThumbnailOnNavigatingAway", base::FEATURE_DISABLED_BY_DEFAULT};
 
+// Enables change picture video mode.
+const base::Feature kChangePictureVideoMode{"ChangePictureVideoMode",
+                                            base::FEATURE_ENABLED_BY_DEFAULT};
+
 // Whether to trigger app banner installability checks on page load.
 const base::Feature kCheckInstallabilityForBannerOnLoad{
     "CheckInstallabilityForBannerOnLoad", base::FEATURE_DISABLED_BY_DEFAULT};

chrome/common/chrome_features.h

@@ -73,6 +73,8 @@ extern const base::Feature kCaptureThumbnailDependingOnTransitionType;
 
 extern const base::Feature kCaptureThumbnailOnNavigatingAway;
 
+extern const base::Feature kChangePictureVideoMode;
+
 extern const base::Feature kCheckInstallabilityForBannerOnLoad;
 
 #if defined(OS_ANDROID)