ash: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=sky, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2110643002
Cr-Commit-Position: refs/heads/master@{#402668}

ash/accelerators/accelerator_controller.cc

@@ -184,7 +184,7 @@ void ShowDeprecatedAcceleratorNotification(const char* const notification_id,
 
 void RecordUmaHistogram(const char* histogram_name,
                         DeprecatedAcceleratorUsage sample) {
-  auto histogram = base::LinearHistogram::FactoryGet(
+  auto* histogram = base::LinearHistogram::FactoryGet(
       histogram_name, 1, DEPRECATED_USAGE_COUNT, DEPRECATED_USAGE_COUNT + 1,
       base::HistogramBase::kUmaTargetedHistogramFlag);
   histogram->Add(sample);

ash/common/wm/overview/scoped_transform_overview_window.cc

@@ -284,14 +284,14 @@ void ScopedTransformOverviewWindow::RestoreWindow() {
 void ScopedTransformOverviewWindow::BeginScopedAnimation(
     OverviewAnimationType animation_type,
     ScopedAnimationSettings* animation_settings) {
-  for (const auto& window : GetTransientTreeIterator(window_)) {
+  for (auto* window : GetTransientTreeIterator(window_)) {
     animation_settings->push_back(
         CreateScopedOverviewAnimationSettings(animation_type, window));
   }
 }
 
 bool ScopedTransformOverviewWindow::Contains(const WmWindow* target) const {
-  for (const auto& window : GetTransientTreeIterator(window_)) {
+  for (auto* window : GetTransientTreeIterator(window_)) {
     if (window->Contains(target))
       return true;
   }
@@ -300,7 +300,7 @@ bool ScopedTransformOverviewWindow::Contains(const WmWindow* target) const {
 
 gfx::Rect ScopedTransformOverviewWindow::GetTargetBoundsInScreen() const {
   gfx::Rect bounds;
-  for (const auto& window : GetTransientTreeIterator(window_)) {
+  for (auto* window : GetTransientTreeIterator(window_)) {
     // Ignore other window types when computing bounding box of window
     // selector target item.
     if (window != window_ && window->GetType() != ui::wm::WINDOW_TYPE_NORMAL &&
@@ -397,7 +397,7 @@ void ScopedTransformOverviewWindow::SetTransform(
 
   gfx::Point target_origin(GetTargetBoundsInScreen().origin());
 
-  for (const auto& window : GetTransientTreeIterator(window_)) {
+  for (auto* window : GetTransientTreeIterator(window_)) {
     WmWindow* parent_window = window->GetParent();
     gfx::Point original_origin =
         parent_window->ConvertRectToScreen(window->GetTargetBounds()).origin();
@@ -410,7 +410,7 @@ void ScopedTransformOverviewWindow::SetTransform(
 }
 
 void ScopedTransformOverviewWindow::SetOpacity(float opacity) {
-  for (const auto& window : GetTransientTreeIterator(window_)) {
+  for (auto* window : GetTransientTreeIterator(window_)) {
     window->SetOpacity(opacity);
   }
 }

ash/common/wm/overview/window_grid.cc

@@ -411,7 +411,7 @@ WindowGrid::WindowGrid(WmWindow* root_window,
       selected_index_(0),
       num_columns_(0) {
   std::vector<WmWindow*> windows_in_root;
-  for (auto window : windows) {
+  for (auto* window : windows) {
     if (window->GetRootWindow() == root_window)
       windows_in_root.push_back(window);
   }
@@ -424,7 +424,7 @@ WindowGrid::WindowGrid(WmWindow* root_window,
     ReorderItemsGreedyLeastMovement(&windows_in_root, root_window_,
                                     window_selector_->text_filter_bottom());
   }
-  for (auto window : windows_in_root) {
+  for (auto* window : windows_in_root) {
     window->AddObserver(this);
     observed_windows_.insert(window);
     window_list_.push_back(new WindowSelectorItem(window, window_selector_));
@@ -907,7 +907,7 @@ bool WindowGrid::FitWindowRectsInBounds(const gfx::Rect& bounds,
   // necessary to determine each item's scale.
   const gfx::Size item_size(0, height);
   size_t i = 0;
-  for (auto window : window_list_) {
+  for (auto* window : window_list_) {
     const gfx::Rect target_bounds = window->GetWindow()->GetTargetBounds();
     const int width =
         std::max(1, gfx::ToFlooredInt(target_bounds.width() *

ash/common/wm/workspace/workspace_layout_manager.cc

@@ -358,7 +358,7 @@ void WorkspaceLayoutManager::UpdateAlwaysOnTop(WmWindow* window_on_top) {
   // always_on_top containers' layouts are managed by this class all the
   // appropriate windows will be included in the iteration.
   WindowSet windows(windows_);
-  for (auto window : windows) {
+  for (auto* window : windows) {
     wm::WindowState* window_state = window->GetWindowState();
     if (window_on_top)
       window_state->DisableAlwaysOnTop(window_on_top);

ash/display/display_util.cc

@@ -465,7 +465,7 @@ void ShowDisplayErrorNotification(int message_id) {
 base::string16 GetDisplayErrorNotificationMessageForTest() {
   message_center::NotificationList::Notifications notifications =
       message_center::MessageCenter::Get()->GetVisibleNotifications();
-  for (auto const notification : notifications) {
+  for (auto* const notification : notifications) {
     if (notification->id() == kDisplayErrorNotificationId)
       return notification->message();
   }

ash/host/ash_window_tree_host_unified.cc

@@ -63,7 +63,7 @@ AshWindowTreeHostUnified::~AshWindowTreeHostUnified() {
 void AshWindowTreeHostUnified::PrepareForShutdown() {
   AshWindowTreeHostPlatform::PrepareForShutdown();
 
-  for (auto host : mirroring_hosts_)
+  for (auto* host : mirroring_hosts_)
     host->PrepareForShutdown();
 }
 
@@ -84,12 +84,12 @@ void AshWindowTreeHostUnified::SetBounds(const gfx::Rect& bounds) {
 }
 
 void AshWindowTreeHostUnified::SetCursorNative(gfx::NativeCursor cursor) {
-  for (auto host : mirroring_hosts_)
+  for (auto* host : mirroring_hosts_)
     host->AsWindowTreeHost()->SetCursor(cursor);
 }
 
 void AshWindowTreeHostUnified::OnCursorVisibilityChangedNative(bool show) {
-  for (auto host : mirroring_hosts_)
+  for (auto* host : mirroring_hosts_)
     host->AsWindowTreeHost()->OnCursorVisibilityChanged(show);
 }
 

ash/mus/layout_manager.cc

@@ -26,7 +26,7 @@ void LayoutManager::Uninstall() {
   if (!owner_)
     return;
   owner_->RemoveObserver(this);
-  for (auto child : owner_->children())
+  for (auto* child : owner_->children())
     child->RemoveObserver(this);
   owner_ = nullptr;
 }
@@ -58,7 +58,7 @@ void LayoutManager::OnWindowBoundsChanged(::mus::Window* window,
     return;
 
   // Changes to the container's bounds require all windows to be laid out.
-  for (auto child : window->children())
+  for (auto* child : window->children())
     LayoutWindow(child);
 }
 

ash/mus/user_window_controller_impl.cc

@@ -125,7 +125,7 @@ void UserWindowControllerImpl::AssignIdIfNecessary(::mus::Window* window) {
 void UserWindowControllerImpl::RemoveObservers(::mus::Window* user_container) {
   user_container->RemoveObserver(this);
   user_container->window_tree()->RemoveObserver(this);
-  for (auto iter : user_container->children())
+  for (auto* iter : user_container->children())
     iter->RemoveObserver(window_property_observer_.get());
 }
 

ash/mus/window_manager.cc

@@ -220,7 +220,7 @@ bool WindowManager::OnWmSetProperty(
 void WindowManager::OnWmClientJankinessChanged(
     const std::set<::mus::Window*>& client_windows,
     bool janky) {
-  for (auto window : client_windows)
+  for (auto* window : client_windows)
     SetWindowIsJanky(window, janky);
 }
 

ash/shelf/shelf_layout_manager_unittest.cc

@@ -1154,7 +1154,7 @@ TEST_F(ShelfLayoutManagerTest, DimmingBehaviorDualDisplay) {
   EXPECT_EQ(root_windows.size(), 2U);
 
   std::vector<ShelfWidget*> shelf_widgets;
-  for (auto& root_window : root_windows) {
+  for (auto* root_window : root_windows) {
     ShelfLayoutManager* shelf =
         GetRootWindowController(root_window)->GetShelfLayoutManager();
     shelf_widgets.push_back(shelf->shelf_widget());

ash/system/toast/toast_overlay.cc

@@ -173,7 +173,7 @@ ToastOverlayView::ToastOverlayView(ToastOverlay* overlay,
 
   AddChildView(button_);
 
-  auto layout = new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 0);
+  auto* layout = new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 0);
   SetLayoutManager(layout);
   layout->SetFlexForView(label, 1);
   layout->SetFlexForView(button_, 0);