Commit ebaaed67 authored by thakis's avatar thakis Committed by Commit bot

reflow comments in modules/[mediasource,plugins]

BUG=563793

Review-Url: https://codereview.chromium.org/2395543002
Cr-Commit-Position: refs/heads/master@{#423050}
parent b5a068ca
...@@ -44,8 +44,8 @@ TrackDefaultList* TrackDefaultList::create( ...@@ -44,8 +44,8 @@ TrackDefaultList* TrackDefaultList::create(
} }
} }
// 2. Store a shallow copy of |trackDefaults| in this new object so the values can // 2. Store a shallow copy of |trackDefaults| in this new object so the values
// be returned by the accessor methods. // can be returned by the accessor methods.
// This step is done in constructor initializer. // This step is done in constructor initializer.
return new TrackDefaultList(trackDefaults); return new TrackDefaultList(trackDefaults);
} }
......
...@@ -38,7 +38,8 @@ namespace blink { ...@@ -38,7 +38,8 @@ namespace blink {
String URLMediaSource::createObjectURL(ExecutionContext* executionContext, String URLMediaSource::createObjectURL(ExecutionContext* executionContext,
MediaSource* source) { MediaSource* source) {
// Since WebWorkers cannot obtain MediaSource objects, we should be on the main thread. // Since WebWorkers cannot obtain MediaSource objects, we should be on the
// main thread.
DCHECK(isMainThread()); DCHECK(isMainThread());
DCHECK(executionContext); DCHECK(executionContext);
DCHECK(source); DCHECK(source);
......
...@@ -108,7 +108,8 @@ static bool verifyCustomHandlerScheme(const String& scheme, ...@@ -108,7 +108,8 @@ static bool verifyCustomHandlerScheme(const String& scheme,
} }
if (scheme.startsWith("web+")) { if (scheme.startsWith("web+")) {
// The specification requires that the length of scheme is at least five characteres (including 'web+' prefix). // The specification requires that the length of scheme is at least five
// characteres (including 'web+' prefix).
if (scheme.length() >= 5) if (scheme.length() >= 5)
return true; return true;
......
...@@ -26,7 +26,9 @@ NavigatorContentUtilsClient::CustomHandlersState ...@@ -26,7 +26,9 @@ NavigatorContentUtilsClient::CustomHandlersState
NavigatorContentUtilsClientMock::isProtocolHandlerRegistered( NavigatorContentUtilsClientMock::isProtocolHandlerRegistered(
const String& scheme, const String& scheme,
const KURL& url) { const KURL& url) {
// "declined" state is checked by NavigatorContentUtils::isProtocolHandlerRegistered() before calling this function. // "declined" state is checked by
// NavigatorContentUtils::isProtocolHandlerRegistered() before calling this
// function.
if (m_protocolMap.contains(scheme)) if (m_protocolMap.contains(scheme))
return NavigatorContentUtilsClient::CustomHandlersRegistered; return NavigatorContentUtilsClient::CustomHandlersRegistered;
......
...@@ -55,8 +55,8 @@ NetworkInformation::~NetworkInformation() { ...@@ -55,8 +55,8 @@ NetworkInformation::~NetworkInformation() {
} }
String NetworkInformation::type() const { String NetworkInformation::type() const {
// m_type is only updated when listening for events, so ask networkStateNotifier // m_type is only updated when listening for events, so ask
// if not listening (crbug.com/379841). // networkStateNotifier if not listening (crbug.com/379841).
if (!m_observing) if (!m_observing)
return connectionTypeToString(networkStateNotifier().connectionType()); return connectionTypeToString(networkStateNotifier().connectionType());
......
...@@ -171,12 +171,12 @@ struct TypeConverter<WTFArray<PaymentMethodDataPtr>, ...@@ -171,12 +171,12 @@ struct TypeConverter<WTFArray<PaymentMethodDataPtr>,
namespace blink { namespace blink {
namespace { namespace {
// If the website does not call complete() 60 seconds after show() has been resolved, then behave as if // If the website does not call complete() 60 seconds after show() has been
// the website called complete("fail"). // resolved, then behave as if the website called complete("fail").
static const int completeTimeoutSeconds = 60; static const int completeTimeoutSeconds = 60;
// Validates ShippingOption or PaymentItem, which happen to have identical fields, // Validates ShippingOption or PaymentItem, which happen to have identical
// except for "id", which is present only in ShippingOption. // fields, except for "id", which is present only in ShippingOption.
template <typename T> template <typename T>
void validateShippingOptionOrPaymentItem(const T& item, void validateShippingOptionOrPaymentItem(const T& item,
ExceptionState& exceptionState) { ExceptionState& exceptionState) {
......
...@@ -15,8 +15,9 @@ ...@@ -15,8 +15,9 @@
namespace blink { namespace blink {
namespace { namespace {
static const int abortTimeout = // Reject the payment request if the page does not resolve the promise from
60; // Reject the payment request if the page does not resolve the promise from updateWith within 60 seconds. // updateWith within 60 seconds.
static const int abortTimeout = 60;
class UpdatePaymentDetailsFunction : public ScriptFunction { class UpdatePaymentDetailsFunction : public ScriptFunction {
public: public:
......
...@@ -16,12 +16,15 @@ class MODULES_EXPORT PaymentsValidators final { ...@@ -16,12 +16,15 @@ class MODULES_EXPORT PaymentsValidators final {
STATIC_ONLY(PaymentsValidators); STATIC_ONLY(PaymentsValidators);
public: public:
// The most common identifiers are three-letter alphabetic codes as defined by [ISO4217] (for example, "USD" for US Dollars) // The most common identifiers are three-letter alphabetic codes as defined by
// however any string of at most 2048 characters is considered valid. Returns false if currency |code| is too long (greater than 2048). // [ISO4217] (for example, "USD" for US Dollars) however any string of at most
// 2048 characters is considered valid. Returns false if currency |code| is
// too long (greater than 2048).
static bool isValidCurrencyCodeFormat(const String& code, static bool isValidCurrencyCodeFormat(const String& code,
String* optionalErrorMessage); String* optionalErrorMessage);
// Returns true if |amount| is a valid currency code as defined in ISO 20022 CurrencyAnd30Amount. // Returns true if |amount| is a valid currency code as defined in ISO 20022
// CurrencyAnd30Amount.
static bool isValidAmountFormat(const String& amount, static bool isValidAmountFormat(const String& amount,
String* optionalErrorMessage); String* optionalErrorMessage);
......
...@@ -13,7 +13,8 @@ ...@@ -13,7 +13,8 @@
* *
* You should have received a copy of the GNU Lesser General Public * You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software * License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
* MA 02110-1301 USA
*/ */
#include "modules/plugins/DOMMimeType.h" #include "modules/plugins/DOMMimeType.h"
......
...@@ -14,7 +14,8 @@ ...@@ -14,7 +14,8 @@
* *
* You should have received a copy of the GNU Lesser General Public * You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software * License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
* MA 02110-1301 USA
*/ */
#include "modules/plugins/DOMMimeTypeArray.h" #include "modules/plugins/DOMMimeTypeArray.h"
......
...@@ -13,7 +13,8 @@ ...@@ -13,7 +13,8 @@
* *
* You should have received a copy of the GNU Lesser General Public * You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software * License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
* MA 02110-1301 USA
*/ */
#include "modules/plugins/DOMPlugin.h" #include "modules/plugins/DOMPlugin.h"
......
...@@ -14,7 +14,8 @@ ...@@ -14,7 +14,8 @@
* *
* You should have received a copy of the GNU Lesser General Public * You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software * License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
* MA 02110-1301 USA
*/ */
#include "modules/plugins/DOMPluginArray.h" #include "modules/plugins/DOMPluginArray.h"
......
...@@ -41,7 +41,8 @@ ...@@ -41,7 +41,8 @@
#include "platform/Widget.h" #include "platform/Widget.h"
#include "wtf/HashSet.h" #include "wtf/HashSet.h"
// This file provides a utility function to support rendering certain elements above plugins. // This file provides a utility function to support rendering certain elements
// above plugins.
namespace blink { namespace blink {
...@@ -79,11 +80,11 @@ static bool iframeIsAbovePlugin( ...@@ -79,11 +80,11 @@ static bool iframeIsAbovePlugin(
return false; return false;
} }
// If the plugin does not have an explicit z-index it stacks behind the iframe. // If the plugin does not have an explicit z-index it stacks behind the
// This is for maintaining compatibility with IE. // iframe. This is for maintaining compatibility with IE.
if (!ro2->isPositioned()) { if (!ro2->isPositioned()) {
// The 0'th elements of these LayoutObject arrays represent the plugin node and // The 0'th elements of these LayoutObject arrays represent the plugin
// the iframe. // node and the iframe.
const LayoutObject* pluginLayoutObject = pluginZstack[0]; const LayoutObject* pluginLayoutObject = pluginZstack[0];
const LayoutObject* iframeLayoutObject = iframeZstack[0]; const LayoutObject* iframeLayoutObject = iframeZstack[0];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment