Migrate references to the viz::mojom::FrameSinkVideoCaptureOverlay interface

Convert the remaining bits in both the implementation and clients from
the browser and renderer processes for the FrameSinkVideoCaptureOverlay
interface, and adapt unit tests.

Bug: 955171, 978694
Change-Id: Ib835dfbe4a84a8ac5abfef5bbaf3945ad5f3fa61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863291Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#708958}

components/viz/host/client_frame_sink_video_capturer.cc

@@ -267,12 +267,12 @@ void ClientFrameSinkVideoCapturer::Overlay::EstablishConnection(
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
   DCHECK(client_capturer_);
 
-  capturer->CreateOverlay(stacking_index_, mojo::MakeRequest(&overlay_));
-  // Note: There's no need to add a connection error handler on the
-  // InterfacePtr. If the connection to the service is lost, the
-  // ClientFrameSinkVideoCapturer will realize this when the
-  // FrameSinkVideoCapturer's binding is lost, and re-establish a connection to
-  // both that and this overlay.
+  capturer->CreateOverlay(stacking_index_,
+                          overlay_.BindNewPipeAndPassReceiver());
+  // Note: There's no need to add a connection error handler on the remote. If
+  // the connection to the service is lost, the ClientFrameSinkVideoCapturer
+  // will realize this when the FrameSinkVideoCapturer's binding is lost, and
+  // re-establish a connection to both that and this overlay.
 
   if (!image_.isNull())
     overlay_->SetImageAndBounds(image_, bounds_);

components/viz/host/client_frame_sink_video_capturer.h

@@ -58,7 +58,7 @@ class VIZ_HOST_EXPORT ClientFrameSinkVideoCapturer
 
     base::WeakPtr<ClientFrameSinkVideoCapturer> client_capturer_;
     const int32_t stacking_index_;
-    mojom::FrameSinkVideoCaptureOverlayPtr overlay_;
+    mojo::Remote<mojom::FrameSinkVideoCaptureOverlay> overlay_;
 
     SkBitmap image_;
     gfx::RectF bounds_;

components/viz/service/frame_sinks/video_capture/video_capture_overlay_unittest.cc

@@ -129,16 +129,17 @@ class VideoCaptureOverlayTest : public testing::Test {
   DISALLOW_COPY_AND_ASSIGN(VideoCaptureOverlayTest);
 };
 
-// Tests that, when the VideoCaptureOverlay binds to a mojo request, it reports
-// when the binding is closed.
+// Tests that, when the VideoCaptureOverlay binds to a mojo pending receiver, it
+// reports when the receiver is closed.
 TEST_F(VideoCaptureOverlayTest, ReportsLostMojoConnection) {
-  mojom::FrameSinkVideoCaptureOverlayPtr overlay_ptr;
-  VideoCaptureOverlay overlay(frame_source(), mojo::MakeRequest(&overlay_ptr));
-  ASSERT_TRUE(overlay_ptr);
+  mojo::Remote<mojom::FrameSinkVideoCaptureOverlay> overlay_remote;
+  VideoCaptureOverlay overlay(frame_source(),
+                              overlay_remote.BindNewPipeAndPassReceiver());
+  ASSERT_TRUE(overlay_remote);
   RunUntilIdle();  // Propagate mojo tasks.
 
   EXPECT_CALL(*frame_source(), OnOverlayConnectionLost(&overlay));
-  overlay_ptr.reset();
+  overlay_remote.reset();
   RunUntilIdle();  // Propagate mojo tasks.
 }