Skip to content

GitLab

T
tangled
Commit ebc921ca authored by dpapad's avatar dpapad Committed by Commit Bot
Browse files
Options

WebUI cleanup: Remove jstemplate_compiled.js from various WebUI pages. 

These pages do not seem to be using that dependency, so it's unnecassary.
This is in preparation of disallowing eval/Function for all WebUI pages that don't
need it (and jstemplate_compiled.js implies that Function is needed).

Pages affected:
chrome://devices
chrome://dom-distiller
chrome://predictors
chrome://webrtc-logs

Also removing such dependency from the "Feedback" component extension.

Bug: 525224
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I31728d2b3323f860c6b65455b0c72873981c4805
Reviewed-on: https://chromium-review.googlesource.com/1088157Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarHenrik Grunell <grunell@chromium.org>
Reviewed-by: default avatarTommy Nyquist <nyquist@chromium.org>
Reviewed-by: default avatarBenoit L <lizeb@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565724}
parent 1e07aadc
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 9 deletions
chrome/browser/resources/feedback/html/sys_info.html
View file @ ebc921ca
......@@ -9,7 +9,6 @@
<link rel="stylesheet" href="../css/sys_info.css">
<script src="chrome://resources/js/util.js"></script>
<script src="chrome://resources/js/i18n_template_no_process.js"></script>
<script src="chrome://resources/js/jstemplate_compiled.js"></script>
<script src="../js/sys_info.js"></script>
</head>
<body>
......@@ -31,4 +30,4 @@
<table class="list" id="detailsTable"></table>
</div>
</body>
</html>
\ No newline at end of file
</html>
chrome/browser/resources/local_discovery/local_discovery.html
View file @ ebc921ca
......@@ -162,6 +162,5 @@
</div>
<script src="chrome://resources/js/i18n_template.js"></script>
<script src="chrome://resources/js/jstemplate_compiled.js"></script>
</body>
</html>
chrome/browser/resources/media/webrtc_logs.html
View file @ ebc921ca
......@@ -7,8 +7,8 @@
<link rel="stylesheet" href="webrtc_logs.css">
<script src="chrome://resources/js/load_time_data.js"></script>
<script src="chrome://resources/js/util.js"></script>
<script src="chrome://webrtc-logs/strings.js"></script>
<script src="chrome://webrtc-logs/webrtc_logs.js"></script>
<script src="strings.js"></script>
<script src="webrtc_logs.js"></script>
</head>
<body>
<header><h1>$i18n{webrtcLogsTitle}</h1></header>
......@@ -16,6 +16,5 @@
<div id="log-list"></div>
<p id="no-logs" hidden>$i18n{noLogsMessage}</p>
<script src="chrome://resources/js/i18n_template.js"></script>
<script src="chrome://resources/js/jstemplate_compiled.js"></script>
</body>
</html>
chrome/browser/resources/predictors/predictors.html
View file @ ebc921ca
......@@ -35,7 +35,6 @@
</tabpanel>
</tabpanels>
</tabbox>
<script src="chrome://resources/js/jstemplate_compiled.js"></script>
<script src="chrome://predictors/predictors.js"></script>
<script src="predictors.js"></script>
</body>
</html>
components/dom_distiller/webui/resources/about_dom_distiller.html
View file @ ebc921ca
......@@ -48,6 +48,5 @@ found in the LICENSE file.
</div>
</div>
<script src="chrome://resources/js/i18n_template.js"></script>
<script src="chrome://resources/js/jstemplate_compiled.js"></script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment