Commit ebcab0b9 authored by Andres Olivares's avatar Andres Olivares Committed by Chromium LUCI CQ

Modify layout test for closing the Request Details panel

The 'Escape' key is used in multiple keybinds that collide with each other
and thus, the action that is effectively triggered cannot be known
beforehand. This test relied on the usage of such key and on the specific
order in which actions were loaded. Now, with the migration of extensions
out of module.json files, the order for loading actions is altered and this
tests starts failing in consequence.

This change modifies the test so that the tested behaviour is triggered
without relying on the usage of the 'Escape' key.

Bug: 1134103
Change-Id: I508704d4507f24441988a837c06f5c009817a91a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586533Reviewed-by: default avatarTim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836632}
parent 65dea946
...@@ -18,8 +18,7 @@ ...@@ -18,8 +18,7 @@
TestRunner.addResult('Network Item View: ' + (panel._networkItemView && panel._networkItemView.isShowing())); TestRunner.addResult('Network Item View: ' + (panel._networkItemView && panel._networkItemView.isShowing()));
TestRunner.addResult('Hiding request'); TestRunner.addResult('Hiding request');
eventSender.keyDown('Escape'); panel._hideRequestPanel();
await TestRunner.addSnifferPromise(Network.NetworkPanel.ActionDelegate.prototype, 'handleAction')
TestRunner.addResult('Network Item View: ' + (panel._networkItemView && panel._networkItemView.isShowing())); TestRunner.addResult('Network Item View: ' + (panel._networkItemView && panel._networkItemView.isShowing()));
TestRunner.completeTest(); TestRunner.completeTest();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment