Commit ebe937e1 authored by ckitagawa's avatar ckitagawa Committed by Commit Bot

[Paint Preview] Add first paint check to player test

Check for first paint before proceeding.

Bug: 1136907, 1136956
Change-Id: Ibcd835a07ed9ba120873b07081824f03674fc41e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469262
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: default avatarMehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817059}
parent 2837464c
...@@ -365,6 +365,7 @@ public class PaintPreviewPlayerTest extends DummyUiActivityTestCase { ...@@ -365,6 +365,7 @@ public class PaintPreviewPlayerTest extends DummyUiActivityTestCase {
mLinkClickHandler = new TestLinkClickHandler(); mLinkClickHandler = new TestLinkClickHandler();
mRefreshedCallback = new CallbackHelper(); mRefreshedCallback = new CallbackHelper();
CallbackHelper viewReady = new CallbackHelper(); CallbackHelper viewReady = new CallbackHelper();
CallbackHelper firstPaint = new CallbackHelper();
mInitializationFailed = false; mInitializationFailed = false;
PostTask.postTask(UiThreadTaskTraits.DEFAULT, () -> { PostTask.postTask(UiThreadTaskTraits.DEFAULT, () -> {
...@@ -389,7 +390,9 @@ public class PaintPreviewPlayerTest extends DummyUiActivityTestCase { ...@@ -389,7 +390,9 @@ public class PaintPreviewPlayerTest extends DummyUiActivityTestCase {
} }
@Override @Override
public void onFirstPaint() {} public void onFirstPaint() {
firstPaint.notifyCalled();
}
@Override @Override
public void onUserInteraction() {} public void onUserInteraction() {}
...@@ -441,6 +444,12 @@ public class PaintPreviewPlayerTest extends DummyUiActivityTestCase { ...@@ -441,6 +444,12 @@ public class PaintPreviewPlayerTest extends DummyUiActivityTestCase {
if (mInitializationFailed) { if (mInitializationFailed) {
Assert.fail("Compositor may have crashed."); Assert.fail("Compositor may have crashed.");
} }
try {
firstPaint.waitForFirst();
} catch (Exception e) {
Assert.fail("First paint not issued.");
}
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment