Commit ec3eb0ad authored by dpranke's avatar dpranke Committed by Commit bot

Fix lint targets 'properly' in build/android/buildbot/bb_device_steps.py

Blink's lint-test-expectations script doesn't actually require any
command line args, and we shouldn't generally use them on the bots.

TBR=cmp@chromium.org, tfarina@chromium.org
BUG=338338, 418017

Review URL: https://codereview.chromium.org/605383002

Cr-Commit-Position: refs/heads/master@{#297043}
parent 97076f1a
...@@ -26,7 +26,7 @@ from pylib.gtest import gtest_config ...@@ -26,7 +26,7 @@ from pylib.gtest import gtest_config
CHROME_SRC_DIR = bb_utils.CHROME_SRC CHROME_SRC_DIR = bb_utils.CHROME_SRC
DIR_BUILD_ROOT = os.path.dirname(CHROME_SRC_DIR) DIR_BUILD_ROOT = os.path.dirname(CHROME_SRC_DIR)
CHROME_OUT_DIR = bb_utils.CHROME_OUT_DIR CHROME_OUT_DIR = bb_utils.CHROME_OUT_DIR
BK_SCRIPTS_DIR = 'third_party/WebKit/Tools/Scripts' BLINK_SCRIPTS_DIR = 'third_party/WebKit/Tools/Scripts'
SLAVE_SCRIPTS_DIR = os.path.join(bb_utils.BB_BUILD_DIR, 'scripts', 'slave') SLAVE_SCRIPTS_DIR = os.path.join(bb_utils.BB_BUILD_DIR, 'scripts', 'slave')
LOGCAT_DIR = os.path.join(bb_utils.CHROME_OUT_DIR, 'logcat') LOGCAT_DIR = os.path.join(bb_utils.CHROME_OUT_DIR, 'logcat')
...@@ -287,8 +287,7 @@ def RunInstrumentationSuite(options, test, flunk_on_failure=True, ...@@ -287,8 +287,7 @@ def RunInstrumentationSuite(options, test, flunk_on_failure=True,
def RunWebkitLint(): def RunWebkitLint():
"""Lint WebKit's TestExpectation files.""" """Lint WebKit's TestExpectation files."""
bb_annotations.PrintNamedStep('webkit_lint') bb_annotations.PrintNamedStep('webkit_lint')
RunCmd([SrcPath(os.path.join(BK_SCRIPTS_DIR, 'lint-test-expectations')), RunCmd([SrcPath(os.path.join(BLINK_SCRIPTS_DIR, 'lint-test-expectations'))])
'--android'])
def RunWebkitLayoutTests(options): def RunWebkitLayoutTests(options):
...@@ -326,7 +325,7 @@ def RunWebkitLayoutTests(options): ...@@ -326,7 +325,7 @@ def RunWebkitLayoutTests(options):
['--additional-expectations=%s' % os.path.join(CHROME_SRC_DIR, *f)]) ['--additional-expectations=%s' % os.path.join(CHROME_SRC_DIR, *f)])
exit_code = RunCmd( exit_code = RunCmd(
[SrcPath(os.path.join(BK_SCRIPTS_DIR, 'run-webkit-tests'))] + cmd_args) [SrcPath(os.path.join(BLINK_SCRIPTS_DIR, 'run-webkit-tests'))] + cmd_args)
if exit_code == 255: # test_run_results.UNEXPECTED_ERROR_EXIT_STATUS if exit_code == 255: # test_run_results.UNEXPECTED_ERROR_EXIT_STATUS
bb_annotations.PrintMsg('?? (crashed or hung)') bb_annotations.PrintMsg('?? (crashed or hung)')
elif exit_code == 254: # test_run_results.NO_DEVICES_EXIT_STATUS elif exit_code == 254: # test_run_results.NO_DEVICES_EXIT_STATUS
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment