Commit ec4385a6 authored by Azeem Arshad's avatar Azeem Arshad Committed by Commit Bot

Revert "Network settings: Add tooltip to eye icon-button"

This reverts commit f4914fbf.

Reason for revert: The paper-tooltip overflows outside of modal dialog boxes and results in unwanted horizontal scrollbars. see https://crbug.com/1055266. This fix should implement the tooltip in such a way that fits correctly inside the container.

Original change's description:
> Network settings: Add tooltip to eye icon-button
>
>
> Bug: 873114
> Change-Id: I05cef0d2a7e53c1bc965764e2b83aefd502753cf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993828
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
> Cr-Commit-Position: refs/heads/master@{#732662}

TBR=dpapad@chromium.org,raleksandrov@google.com,johntlee@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 873114, 1055266
Change-Id: I0b7561abaf41a597556cc2e0e8d0481101eeab10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086351
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: default avatarAzeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746621}
parent 420d2c7c
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
<link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network_indicator_mojo.html"> <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network_indicator_mojo.html">
<link rel="import" href="chrome://resources/cr_elements/shared_vars_css.html"> <link rel="import" href="chrome://resources/cr_elements/shared_vars_css.html">
<link rel="import" href="chrome://resources/html/i18n_behavior.html"> <link rel="import" href="chrome://resources/html/i18n_behavior.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-tooltip/paper-tooltip.html">
<link rel="import" href="network_config_element_behavior.html"> <link rel="import" href="network_config_element_behavior.html">
<link rel="import" href="network_shared_css.html"> <link rel="import" href="network_shared_css.html">
...@@ -23,13 +22,6 @@ ...@@ -23,13 +22,6 @@
flex: 1; flex: 1;
} }
paper-tooltip {
--paper-tooltip: {
@apply --cr-tooltip;
min-width: 0;
};
}
cr-policy-network-indicator-mojo { cr-policy-network-indicator-mojo {
--cr-tooltip-icon-margin-start: var(--cr-controlled-by-spacing); --cr-tooltip-icon-margin-start: var(--cr-controlled-by-spacing);
} }
...@@ -48,12 +40,8 @@ ...@@ -48,12 +40,8 @@
<cr-icon-button id="icon" slot="suffix" <cr-icon-button id="icon" slot="suffix"
class$="[[getIconClass_(showPassword)]]" class$="[[getIconClass_(showPassword)]]"
on-click="onShowPasswordTap_" on-click="onShowPasswordTap_"
aria-describedby="tooltip"> title="[[getShowPasswordTitle_(showPassword)]]">
</cr-icon-button> </cr-icon-button>
<paper-tooltip id="tooltip" for="icon" position="top"
fit-to-visible-bounds role="tooltip">
[[getShowPasswordTitle_(showPassword)]]
</paper-tooltip>
</template> </template>
<template is="dom-if" if="[[showPolicyIndicator_]]" restamp> <template is="dom-if" if="[[showPolicyIndicator_]]" restamp>
<cr-policy-network-indicator-mojo <cr-policy-network-indicator-mojo
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment