Commit ec551e52 authored by Kevin McNee's avatar Kevin McNee Committed by Commit Bot

Remove ReportMouseTargetNotInRoot DumpWithoutCrashing

While it's still not clear why this is happening, this DumpWithoutCrashing
is not providing any further information.

Bug: 851958
Change-Id: Ib8066c525c94b8503caf35251c12cc804af20dc6
Reviewed-on: https://chromium-review.googlesource.com/1129858Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573454}
parent 17ee9c1a
...@@ -689,10 +689,11 @@ void RenderWidgetHostInputEventRouter::SendMouseEnterOrLeaveEvents( ...@@ -689,10 +689,11 @@ void RenderWidgetHostInputEventRouter::SendMouseEnterOrLeaveEvents(
entered_views.push_back(cur_view); entered_views.push_back(cur_view);
} }
if (cur_view != root_view) { // On Windows, it appears to be possible that render widget targeting could
ReportMouseTargetNotInRoot(cur_view, root_view); // produce a target that is outside of the specified root. For now, we'll
// just give up in such a case. See https://crbug.com/851958.
if (cur_view != root_view)
return; return;
}
cur_view = last_mouse_move_target_; cur_view = last_mouse_move_target_;
if (cur_view) { if (cur_view) {
...@@ -772,33 +773,6 @@ void RenderWidgetHostInputEventRouter::SendMouseEnterOrLeaveEvents( ...@@ -772,33 +773,6 @@ void RenderWidgetHostInputEventRouter::SendMouseEnterOrLeaveEvents(
last_mouse_move_root_view_ = root_view; last_mouse_move_root_view_ = root_view;
} }
void RenderWidgetHostInputEventRouter::ReportMouseTargetNotInRoot(
RenderWidgetHostViewBase* target_root,
RenderWidgetHostViewBase* specified_root) {
static auto* specified_root_is_child_key =
base::debug::AllocateCrashKeyString("mouse-outside-root-root-is-child",
base::debug::CrashKeySize::Size32);
base::debug::ScopedCrashKeyString specified_root_is_child_key_value(
specified_root_is_child_key,
std::to_string(specified_root->IsRenderWidgetHostViewChildFrame()));
static auto* specified_root_is_mouse_locked_key =
base::debug::AllocateCrashKeyString(
"mouse-outside-root-root-is-mouse-locked",
base::debug::CrashKeySize::Size32);
base::debug::ScopedCrashKeyString specified_root_is_mouse_locked_key_value(
specified_root_is_mouse_locked_key,
std::to_string(specified_root->IsMouseLocked()));
static auto* target_root_is_mouse_locked_key =
base::debug::AllocateCrashKeyString(
"mouse-outside-root-target-root-is-mouse-locked",
base::debug::CrashKeySize::Size32);
base::debug::ScopedCrashKeyString target_root_is_mouse_locked_key_value(
target_root_is_mouse_locked_key,
std::to_string(target_root->IsMouseLocked()));
base::debug::DumpWithoutCrashing();
}
void RenderWidgetHostInputEventRouter::ReportBubblingScrollToSameView( void RenderWidgetHostInputEventRouter::ReportBubblingScrollToSameView(
const blink::WebGestureEvent& event, const blink::WebGestureEvent& event,
const RenderWidgetHostViewBase* view) { const RenderWidgetHostViewBase* view) {
......
...@@ -258,9 +258,6 @@ class CONTENT_EXPORT RenderWidgetHostInputEventRouter ...@@ -258,9 +258,6 @@ class CONTENT_EXPORT RenderWidgetHostInputEventRouter
gfx::PointF* transformed_point, gfx::PointF* transformed_point,
viz::EventSource source) const; viz::EventSource source) const;
// TODO(851958): Remove once we understand the cause of 851958.
void ReportMouseTargetNotInRoot(RenderWidgetHostViewBase* target_root,
RenderWidgetHostViewBase* specified_root);
// TODO(828422): Remove once this issue no longer occurs. // TODO(828422): Remove once this issue no longer occurs.
void ReportBubblingScrollToSameView(const blink::WebGestureEvent& event, void ReportBubblingScrollToSameView(const blink::WebGestureEvent& event,
const RenderWidgetHostViewBase* view); const RenderWidgetHostViewBase* view);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment