Suppress Errors for chrome.alarm.get

Removed the error signalling to prevent log spam from the runtime.lastError
checks for non-existent alarms.

BUG=367136

Review URL: https://codereview.chromium.org/258793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266352 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/extensions/api/alarms/alarms_api.cc

@@ -19,7 +19,6 @@ namespace extensions {
 namespace {
 
 const char kDefaultAlarmName[] = "";
-const char kAlarmNotFound[] = "No alarm named '*' exists.";
 const char kBothRelativeAndAbsoluteTime[] =
     "Cannot set both when and delayInMinutes.";
 const char kNoScheduledTime[] =
@@ -147,11 +146,8 @@ void AlarmsGetFunction::Callback(
     const std::string& name, extensions::Alarm* alarm) {
   if (alarm) {
     results_ = alarms::Get::Results::Create(*alarm->js_alarm);
-    SendResponse(true);
-  } else {
-    error_ = ErrorUtils::FormatErrorMessage(kAlarmNotFound, name);
-    SendResponse(false);
   }
+  SendResponse(true);
 }
 
 bool AlarmsGetAllFunction::RunImpl() {

chrome/browser/extensions/api/alarms/alarms_api_unittest.cc

@@ -323,9 +323,9 @@ TEST_F(ExtensionAlarmsTest, Get) {
 
   // Get a non-existent one.
   {
-    std::string error = RunFunctionAndReturnError(
-        new AlarmsGetFunction(), "[\"nobody\"]");
-    EXPECT_FALSE(error.empty());
+    scoped_ptr<base::DictionaryValue> result(RunFunctionAndReturnDictionary(
+        new AlarmsGetFunction(), "[\"nobody\"]"));
+    ASSERT_FALSE(result.get());
   }
 }