[Extensions] Update ExtensionManagementApiTest to manifest v2

Update ExtensionManagementApiTest to manifest v2 and remove the
allowance for manifest v1 extensions.

Bug: 816679

Change-Id: I0448ee64cbde9ed8431c30090d1f109e6d655fce
Reviewed-on: https://chromium-review.googlesource.com/1014711Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551749}

chrome/browser/extensions/api/management/management_apitest.cc

@@ -44,8 +44,6 @@ Browser* FindOtherBrowser(Browser* browser) {
 
 class ExtensionManagementApiTest : public ExtensionApiTest {
  public:
-  bool ShouldAllowLegacyExtensionManifests() override { return true; }
-
   virtual void LoadExtensions() {
     base::FilePath basedir = test_data_dir_.AppendASCII("management");
 

chrome/test/data/extensions/api_test/management/no_permission/test.js

@@ -4,8 +4,13 @@
 
 var tests = [
   function permissionWarnings() {
-    var manifest_str = "{ \"name\": \"Clipboard!\", \"version\": \"1.0\", " +
-                       "\"permissions\": [\"clipboardRead\"] }";
+    var manifest_str =
+        `{
+           "name": "Clipboard!",
+           "version": "1.0",
+           "manifest_version": 2,
+           "permissions": ["clipboardRead"]
+         }`;
 
     chrome.management.getPermissionWarningsByManifest(
         manifest_str, chrome.test.callback(function(warnings) {

chrome/test/data/extensions/api_test/management/test/basics.js

@@ -100,12 +100,17 @@ var tests = [
   },
 
   function permissionWarnings() {
-    var manifest_str = "{ \"name\": \"Hello World!\", \"version\": \"1.0\", " +
-                       "\"permissions\": [\"http://api.flickr.com/\", " +
-                       "\"bookmarks\", \"geolocation\", " +
-                       "\"history\", \"tabs\"]," +
-                       "\"content_scripts\": [{\"js\": [\"script.js\"], " +
-                       "\"matches\": [\"http://*.flickr.com/*\"]}]}";
+    var manifest_str =
+        `{
+           "name": "Hello World!",
+           "manifest_version": 2,
+           "version": "1.0",
+           "permissions": ["http://api.flickr.com/", "bookmarks", "geolocation",
+                           "history", "tabs"],
+           "content_scripts": [
+             {"js": ["script.js"], "matches": ["http://*.flickr.com/*"]}
+           ]
+         }`;
 
     chrome.management.getPermissionWarningsByManifest(
         manifest_str, callback(function(warnings) {
@@ -134,8 +139,13 @@ var tests = [
   },
 
   function permissionWarningsClipboardReadApi() {
-    var manifest_str = "{ \"name\": \"Clipboard!\", \"version\": \"1.0\", " +
-                       "\"permissions\": [\"clipboardRead\"] }";
+    var manifest_str =
+        `{
+           "name": "Clipboard!",
+           "version": "1.0",
+           "manifest_version": 2,
+           "permissions": ["clipboardRead"]
+         }`;
 
     chrome.management.getPermissionWarningsByManifest(
         manifest_str, callback(function(warnings) {