Commit ec791fb5 authored by Minoru Chikamune's avatar Minoru Chikamune Committed by Commit Bot

Add Recommended / Deprecated comments on HeapMojoWrapperMode

HeapMojoWrapperMode provides tentative modes so that we can keep the original behaviour. But we need to enphasize to use kWithContextObserver.

Bug: 1049056
Change-Id: I4ab677a60f1c91824f83f3c29c6c0c2a3cc9e3ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345935Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796757}
parent 92ec733b
......@@ -11,14 +11,17 @@ namespace blink {
// TODO(crbug.com/1058076) This is just a temporary thing to keep the existing
// behavior during the release freeze.
enum class HeapMojoWrapperMode {
// Resets the mojo connection when 1) the owner object is garbage-collected
// [Recommended] Resets the mojo connection when 1) the owner object is
// garbage-collected
// and 2) the associated ExecutionContext is detached.
kWithContextObserver,
// Resets the mojo connection when the owner object is garbage-collected.
// [Deprecated] Resets the mojo connection when the owner object is
// garbage-collected.
// But, it will not reset the mojo connection when the associated
// ExecutionContext is detached.
kWithoutContextObserver,
// We are now experimenting with deprecating kWithoutContextObserver.
// [Deprecated] We are now experimenting with deprecating
// kWithoutContextObserver.
// kWithoutContextObserver is ignored in the Finch experiment. To enforce
// kWithoutContextObserver, use kForceWithoutContextObserver.
kForceWithoutContextObserver,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment