Commit ec8cc7a1 authored by Manu Cornet's avatar Manu Cornet Committed by Commit Bot

Revert "CrOS Shelf: Remove overflow shelf clip"

This reverts commit 0cee3055.

Reason for revert: This change makes app icons bleed outside of the overflow when there are too many of them.

Original change's description:
> CrOS Shelf: Remove overflow shelf clip
> 
> Remove overflow shelf clip so that inkdrop ripples can propagate
> outside the overflow bubble.
> 
> The mask isn't really useful in the first place anyway.
> 
> See before/after screenshots here:
> 
>     https://bugs.chromium.org/p/chromium/issues/detail?id=631240#c14
> 
> Bug: 631240
> Change-Id: Iaa1d2f4e2e74bff34a708fa9e2cd7be5ed9a52fa
> Reviewed-on: https://chromium-review.googlesource.com/c/1429639
> Auto-Submit: Manu Cornet <manucornet@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#625234}

TBR=xiyuan@chromium.org,manucornet@chromium.org

Change-Id: I51a004caf0a1b516fd21251621e9f716a241ca14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 631240
Reviewed-on: https://chromium-review.googlesource.com/c/1432732Reviewed-by: default avatarManu Cornet <manucornet@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625407}
parent cb521877
...@@ -60,8 +60,10 @@ OverflowBubbleView::OverflowBubbleView(ShelfView* shelf_view, ...@@ -60,8 +60,10 @@ OverflowBubbleView::OverflowBubbleView(ShelfView* shelf_view,
else else
set_margins(gfx::Insets(kEndPadding, 0)); set_margins(gfx::Insets(kEndPadding, 0));
// Makes bubble view has a layer and clip its children layers.
SetPaintToLayer(); SetPaintToLayer();
layer()->SetFillsBoundsOpaquely(false); layer()->SetFillsBoundsOpaquely(false);
layer()->SetMasksToBounds(true);
CreateBubble(); CreateBubble();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment