Commit ec999b8f authored by Friedrich Horschig's avatar Friedrich Horschig Committed by Commit Bot

[PwdCheckAndroid] Remove the change password button

Since the button has no functionality yet, hide it by default.
Advantages of hiding over removing the code:
- it provides the correctly styled button for other experiments
- we can keep the finished translation for now and can reenable it on
  short notice

Bug: 1106277
Change-Id: Ic82ac97b6de43451b15202fbce1dd06d117ec18f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312801
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: default avatarIoana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791233}
parent 24c982a7
...@@ -46,6 +46,7 @@ ...@@ -46,6 +46,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:text="@string/password_check_credential_row_change_button_caption" android:text="@string/password_check_credential_row_change_button_caption"
android:visibility="gone"
style="@style/FilledButton.Flat" /> style="@style/FilledButton.Flat" />
</LinearLayout> </LinearLayout>
......
...@@ -101,7 +101,8 @@ public class PasswordCheckViewTest { ...@@ -101,7 +101,8 @@ public class PasswordCheckViewTest {
pollUiThread(() -> Criteria.checkThat(getCredentials().getChildCount(), is(2))); pollUiThread(() -> Criteria.checkThat(getCredentials().getChildCount(), is(2)));
// Has a change passwords button. // Has a change passwords button.
assertNotNull(getCredentialChangeButtonAt(1)); assertNotNull(getCredentialChangeButtonAt(1));
assertThat(getCredentialChangeButtonAt(1).getVisibility(), is(View.VISIBLE)); // TODO(crbug.com/1092444): Ensure the button is visible as soon as it does something!
assertThat(getCredentialChangeButtonAt(1).getVisibility(), is(View.GONE));
assertThat(getCredentialChangeButtonAt(1).getText(), assertThat(getCredentialChangeButtonAt(1).getText(),
is(getString(R.string.password_check_credential_row_change_button_caption))); is(getString(R.string.password_check_credential_row_change_button_caption)));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment