Commit ecaa39ab authored by Bettina's avatar Bettina Committed by Commit Bot

Enable sampled pings experiment by default.

Previously, the saved passwords with domains
experiment was enabled by default but the sampled
pings experiment was the one that should have enabled
instead.

Bug: 953106
Change-Id: Ie8bae8851f23bdfa09e736cf4a1602c7fd15eaba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012886
Commit-Queue: Bettina Dea <bdea@chromium.org>
Auto-Submit: Bettina Dea <bdea@chromium.org>
Reviewed-by: default avatarVarun Khaneja <vakh@chromium.org>
Reviewed-by: default avatarXinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733792}
parent c2021f1c
...@@ -561,11 +561,11 @@ TEST_F(ChromePasswordProtectionServiceTest, ...@@ -561,11 +561,11 @@ TEST_F(ChromePasswordProtectionServiceTest,
} }
TEST_F(ChromePasswordProtectionServiceTest, VerifyCanSendSamplePing) { TEST_F(ChromePasswordProtectionServiceTest, VerifyCanSendSamplePing) {
// If experiment is not enabled, do not send ping. // Experiment is on by default.
service_->ConfigService(/*is_incognito=*/false, service_->ConfigService(/*is_incognito=*/false,
/*is_extended_reporting=*/true); /*is_extended_reporting=*/true);
service_->set_bypass_probability_for_tests(true); service_->set_bypass_probability_for_tests(true);
EXPECT_FALSE(service_->CanSendSamplePing()); EXPECT_TRUE(service_->CanSendSamplePing());
{ {
base::test::ScopedFeatureList feature_list; base::test::ScopedFeatureList feature_list;
......
...@@ -50,7 +50,7 @@ const base::Feature kPasswordProtectionForSavedPasswords{ ...@@ -50,7 +50,7 @@ const base::Feature kPasswordProtectionForSavedPasswords{
const base::Feature kPasswordProtectionShowDomainsForSavedPasswords{ const base::Feature kPasswordProtectionShowDomainsForSavedPasswords{
"SafeBrowsingPasswordProtectionShowDomainsForSavedPasswords", "SafeBrowsingPasswordProtectionShowDomainsForSavedPasswords",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kPasswordProtectionForSignedInUsers{ const base::Feature kPasswordProtectionForSignedInUsers{
"SafeBrowsingPasswordProtectionForSignedInUsers", "SafeBrowsingPasswordProtectionForSignedInUsers",
...@@ -85,7 +85,7 @@ const base::Feature kSendPasswordReusePing { ...@@ -85,7 +85,7 @@ const base::Feature kSendPasswordReusePing {
const base::Feature kSendSampledPingsForAllowlistDomains{ const base::Feature kSendSampledPingsForAllowlistDomains{
"SafeBrowsingSendSampledPingsForAllowlistDomain", "SafeBrowsingSendSampledPingsForAllowlistDomain",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
constexpr base::FeatureParam<bool> kShouldFillOldPhishGuardProto{ constexpr base::FeatureParam<bool> kShouldFillOldPhishGuardProto{
&kPasswordProtectionForSignedInUsers, "DeprecateOldProto", false}; &kPasswordProtectionForSignedInUsers, "DeprecateOldProto", false};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment