Commit ecab7921 authored by Daniel Bratell's avatar Daniel Bratell Committed by Commit Bot

Switch shader_translator from khronos GL to ui/gl

In jumbo experiments build targets using both ui/gl+mesa and khronos
at the same time fail to compile because the two GL libraries
declare the same constants and functions.

This happened in gpu/command_buffer/service because ShaderTranslator
used khronos GL when it should have been using ui/gl. This patch switches
that code over to ui/gl.

Bug: 864986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I522243374eaf0416df58d84e20585c11aef3de32
Reviewed-on: https://chromium-review.googlesource.com/1145306Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#577236}
parent 516528f8
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include "gpu/command_buffer/service/shader_translator.h" #include "gpu/command_buffer/service/shader_translator.h"
#include <GLES2/gl2.h>
#include <stddef.h> #include <stddef.h>
#include <string.h> #include <string.h>
#include <algorithm> #include <algorithm>
...@@ -15,6 +14,7 @@ ...@@ -15,6 +14,7 @@
#include "base/logging.h" #include "base/logging.h"
#include "base/strings/string_number_conversions.h" #include "base/strings/string_number_conversions.h"
#include "base/trace_event/trace_event.h" #include "base/trace_event/trace_event.h"
#include "ui/gl/gl_bindings.h"
#include "ui/gl/gl_implementation.h" #include "ui/gl/gl_implementation.h"
#include "ui/gl/gl_version_info.h" #include "ui/gl/gl_version_info.h"
......
...@@ -4,8 +4,6 @@ ...@@ -4,8 +4,6 @@
#include "gpu/command_buffer/service/shader_translator_cache.h" #include "gpu/command_buffer/service/shader_translator_cache.h"
#include <GLES2/gl2.h>
namespace gpu { namespace gpu {
namespace gles2 { namespace gles2 {
......
...@@ -2,10 +2,9 @@ ...@@ -2,10 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include <GLES2/gl2.h>
#include "gpu/command_buffer/service/shader_translator_cache.h" #include "gpu/command_buffer/service/shader_translator_cache.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
#include "ui/gl/gl_bindings.h"
namespace gpu { namespace gpu {
namespace gles2 { namespace gles2 {
......
...@@ -2,10 +2,9 @@ ...@@ -2,10 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include <GLES2/gl2.h>
#include "gpu/command_buffer/service/shader_translator.h" #include "gpu/command_buffer/service/shader_translator.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
#include "ui/gl/gl_bindings.h"
#include "ui/gl/gl_version_info.h" #include "ui/gl/gl_version_info.h"
namespace gpu { namespace gpu {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment