AndroidTelemtryService should not create DownloadManagerImpl

Creating DownloadManagerImpl on startup is very costly as it loads
a lot of downloads. So BrowserContext::GetDownloadManager() should
not be called in classes like AndroidTelemetryService, which is
created in browser startup.
This CL fixes the behavior by making AndroidTelemetryService observe
SimpleDownloadManagerCoordinator. The coordinator class is a wrapper
of the DownloadManagerImpl and will not load any history downloads
on startup.

BUG=1003160

Change-Id: Iab9a42071821e01d4f70c779113cf23a2fb534f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799684Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695868}

chrome/browser/safe_browsing/telemetry/android/android_telemetry_service.cc

@@ -13,6 +13,7 @@
 #include "base/files/file_path.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/task/post_task.h"
+#include "chrome/browser/download/simple_download_manager_coordinator_factory.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h"
@@ -78,31 +79,29 @@ AndroidTelemetryService::AndroidTelemetryService(
   DCHECK(profile_);
   DCHECK(sb_service_);
 
-  content::DownloadManager* download_manager =
-      BrowserContext::GetDownloadManager(profile_);
-  if (download_manager) {
-    // Look for new downloads being created.
-    download_manager->AddObserver(this);
-  }
+  download::SimpleDownloadManagerCoordinator* coordinator =
+      SimpleDownloadManagerCoordinatorFactory::GetForKey(
+          profile_->GetProfileKey());
+  coordinator->AddObserver(this);
 }
 
 AndroidTelemetryService::~AndroidTelemetryService() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
-  content::DownloadManager* download_manager =
-      BrowserContext::GetDownloadManager(profile_);
-  if (download_manager) {
-    download_manager->RemoveObserver(this);
-  }
+  download::SimpleDownloadManagerCoordinator* coordinator =
+      SimpleDownloadManagerCoordinatorFactory::GetForKey(
+          profile_->GetProfileKey());
+  coordinator->RemoveObserver(this);
 }
 
 void AndroidTelemetryService::OnDownloadCreated(
-    content::DownloadManager* manager,
     download::DownloadItem* item) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
-  if (!BrowserContext::GetDownloadManager(profile_)->IsManagerInitialized()) {
+  download::SimpleDownloadManagerCoordinator* coordinator =
+      SimpleDownloadManagerCoordinatorFactory::GetForKey(
+          profile_->GetProfileKey());
+  if (!coordinator->has_all_history_downloads())
     return;
-  }
 
   if (!CanSendPing(item)) {
     return;

chrome/browser/safe_browsing/telemetry/android/android_telemetry_service.h

@@ -11,6 +11,7 @@
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/safe_browsing/telemetry/telemetry_service.h"
 #include "components/download/public/common/download_item.h"
+#include "components/download/public/common/simple_download_manager_coordinator.h"
 #include "components/safe_browsing/proto/csd.pb.h"
 #include "content/public/browser/download_manager.h"
 
@@ -57,20 +58,18 @@ enum class ApkDownloadTelemetryOutcome {
 // the perspective of this class:
 // 1. Downloading off-market APKs. See: go/zurkon-v1-referrer-dd
 
-class AndroidTelemetryService : public download::DownloadItem::Observer,
-                                public content::DownloadManager::Observer,
-                                public TelemetryService {
+class AndroidTelemetryService
+    : public download::DownloadItem::Observer,
+      public download::SimpleDownloadManagerCoordinator::Observer,
+      public TelemetryService {
  public:
   AndroidTelemetryService(SafeBrowsingService* sb_service, Profile* profile);
   ~AndroidTelemetryService() override;
 
-  // content::DownloadManager::Observer.
-  // Called when a new download is created.
-  void OnDownloadCreated(content::DownloadManager* manager,
-                         download::DownloadItem* item) override;
+  // download::SimpleDownloadManagerCoordinator::Observer.
+  void OnDownloadCreated(download::DownloadItem* item) override;
 
-  // download::DownloadItem::Observer
-  // Called when the state of a download item changes.
+  // download::DownloadItem::Observer.
   void OnDownloadUpdated(download::DownloadItem* download) override;
 
  private: