Commit ed31a5a6 authored by Dan Beam's avatar Dan Beam Committed by Commit Bot

Convert ==/!= to ===/!== in: //chrome/renderer/

CL generated with:

$ git ls-files 'chrome/renderer/*.js' | xargs grep -l -P ' [!=]= (?!null)' | xargs perl -p -i -e 's/ ([!=])= (?!null)/ \1== /g'

Bug: 720034
Change-Id: I64e170031fdd2087dd3adf50276228fbfaf6fd57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003917
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732257}
parent 5e341638
......@@ -38,13 +38,13 @@ apiBridge.registerCustomHook(function(bindingsAPI) {
apiFunctions.setHandleRequest('inspect', function(options, callback) {
var renderViewId = options.render_view_id;
if (typeof renderViewId == 'string') {
if (typeof renderViewId === 'string') {
renderViewId = parseInt(renderViewId);
if (isNaN(renderViewId))
throw new Error('Invalid value for render_view_id');
}
var renderProcessId = options.render_process_id;
if (typeof renderProcessId == 'string') {
if (typeof renderProcessId === 'string') {
renderProcessId = parseInt(renderProcessId);
if (isNaN(renderProcessId))
throw new Error('Invalid value for render_process_id');
......
......@@ -15,18 +15,20 @@ bindingUtil.registerEventArgumentMassager('downloads.onDeterminingFilename',
function isValidResult(result) {
if (result === undefined)
return false;
if (typeof(result) != 'object') {
console.error('Error: Invocation of form suggest(' + typeof(result) +
') doesn\'t match definition suggest({filename: string, ' +
'conflictAction: string})');
if (typeof result !== 'object') {
console.error(
'Error: Invocation of form suggest(' + typeof result +
') doesn\'t match definition suggest({filename: string, ' +
'conflictAction: string})');
return false;
} else if ((typeof(result.filename) != 'string') ||
(result.filename.length == 0)) {
} else if (
typeof result.filename !== 'string' || result.filename.length === 0) {
console.error('Error: "filename" parameter to suggest() must be a ' +
'non-empty string');
return false;
} else if ([undefined, 'uniquify', 'overwrite', 'prompt'].indexOf(
result.conflictAction) < 0) {
} else if ([
undefined, 'uniquify', 'overwrite', 'prompt'
].indexOf(result.conflictAction) < 0) {
console.error('Error: "conflictAction" parameter to suggest() must be ' +
'one of undefined, "uniquify", "overwrite", "prompt"');
return false;
......@@ -48,10 +50,9 @@ bindingUtil.registerEventArgumentMassager('downloads.onDeterminingFilename',
}
try {
var results = dispatch([downloadItem, suggestCallback]);
var async = (results &&
results.results &&
(results.results.length != 0) &&
(results.results[0] === true));
var async =
(results && results.results && (results.results.length !== 0) &&
(results.results[0] === true));
if (suggestable && !async)
suggestCallback();
} catch (e) {
......
......@@ -44,7 +44,7 @@ function CreateOperationError() {
// returns true.
function catchInvalidTokenError(reject) {
if (chrome.runtime.lastError &&
chrome.runtime.lastError.message == errorInvalidToken) {
chrome.runtime.lastError.message === errorInvalidToken) {
reject(chrome.runtime.lastError);
return true;
}
......
......@@ -41,7 +41,7 @@ function annotateDate(date) {
*/
function verifyImageURI(uri) {
// The URI is specified by a user, so the type may be incorrect.
if (typeof uri != 'string' && !(uri instanceof String))
if (typeof uri !== 'string' && !(uri instanceof String))
return false;
return METADATA_THUMBNAIL_FORMAT.test(uri);
......
......@@ -15,7 +15,7 @@ apiBridge.registerCustomHook(function(bindingsAPI) {
// Validate message.data.
var payloadSize = 0;
forEach(message.data, function(property, value) {
if (property.length == 0)
if (property.length === 0)
throw new Error("One of data keys is empty.");
var lowerCasedProperty = property.toLowerCase();
......@@ -33,7 +33,7 @@ apiBridge.registerCustomHook(function(bindingsAPI) {
throw new Error("Payload exceeded allowed size limit. Payload size is: "
+ payloadSize);
if (payloadSize == 0)
if (payloadSize === 0)
throw new Error("No data to send.");
return arguments;
......
......@@ -12,7 +12,7 @@ apiBridge.registerCustomHook(function(binding, id, contextType) {
path = '/';
else
path = String(path);
if (path[0] != '/')
if (path[0] !== '/')
path = '/' + path;
return 'https://' + id + '.chromiumapp.org' + path;
});
......
......@@ -262,12 +262,12 @@ function MediaSinkExtraDataAdapter(value) {
this.$data = null;
this.$tag = undefined;
if (value == undefined) {
if (value === undefined) {
return;
}
var keys = Object.keys(value);
if (keys.length == 0) {
if (keys.length === 0) {
return;
}
......@@ -295,7 +295,7 @@ MediaSinkExtraDataAdapter.Tags = {
Object.defineProperty(MediaSinkExtraDataAdapter.prototype, 'dial_media_sink', {
get: function() {
if (this.$tag != MediaSinkExtraDataAdapter.Tags.dial_media_sink) {
if (this.$tag !== MediaSinkExtraDataAdapter.Tags.dial_media_sink) {
throw new ReferenceError(
'MediaSinkExtraDataAdapter.dial_media_sink is not currently set.');
}
......@@ -310,7 +310,7 @@ Object.defineProperty(MediaSinkExtraDataAdapter.prototype, 'dial_media_sink', {
Object.defineProperty(MediaSinkExtraDataAdapter.prototype, 'cast_media_sink', {
get: function() {
if (this.$tag != MediaSinkExtraDataAdapter.Tags.cast_media_sink) {
if (this.$tag !== MediaSinkExtraDataAdapter.Tags.cast_media_sink) {
throw new ReferenceError(
'MediaSinkExtraDataAdapter.cast_media_sink is not currently set.');
}
......@@ -324,7 +324,7 @@ Object.defineProperty(MediaSinkExtraDataAdapter.prototype, 'cast_media_sink', {
});
MediaSinkExtraDataAdapter.fromNewVersion = function(other) {
if (other.$tag == mediaRouter.mojom.MediaSinkExtraData.Tags.dialMediaSink) {
if (other.$tag === mediaRouter.mojom.MediaSinkExtraData.Tags.dialMediaSink) {
return new MediaSinkExtraDataAdapter({
'dial_media_sink':
DialMediaSinkAdapter.fromNewVersion(other.dialMediaSink),
......@@ -338,7 +338,7 @@ MediaSinkExtraDataAdapter.fromNewVersion = function(other) {
};
MediaSinkExtraDataAdapter.prototype.toNewVersion = function() {
if (this.$tag == MediaSinkExtraDataAdapter.Tags.dial_media_sink) {
if (this.$tag === MediaSinkExtraDataAdapter.Tags.dial_media_sink) {
return new mediaRouter.mojom.MediaSinkExtraData({
'dialMediaSink': this.dial_media_sink.toNewVersion(),
});
......@@ -550,7 +550,7 @@ function routeToMojo_(route) {
* @return {!mediaRouter.mojom.RouteMessage} A Mojo RouteMessage object.
*/
function messageToMojo_(message) {
if ("string" == typeof message.message) {
if ('string' === typeof message.message) {
return new mediaRouter.mojom.RouteMessage({
'type': mediaRouter.mojom.RouteMessage.Type.TEXT,
'message': message.message,
......
......@@ -46,16 +46,16 @@ function parseOmniboxDescription(input) {
function walk(node) {
for (var i = 0, child; child = node.childNodes[i]; i++) {
// Append text nodes to our description.
if (child.nodeType == Node.TEXT_NODE) {
var shouldTrim = result.description.length == 0;
if (child.nodeType === Node.TEXT_NODE) {
var shouldTrim = result.description.length === 0;
result.description += sanitizeString(child.nodeValue, shouldTrim);
continue;
}
// Process and descend into a subset of recognized tags.
if (child.nodeType == Node.ELEMENT_NODE &&
(child.nodeName == 'dim' || child.nodeName == 'match' ||
child.nodeName == 'url')) {
if (child.nodeType === Node.ELEMENT_NODE &&
(child.nodeName === 'dim' || child.nodeName === 'match' ||
child.nodeName === 'url')) {
var style = {
'type': child.nodeName,
'offset': result.description.length
......@@ -79,14 +79,14 @@ function parseOmniboxDescription(input) {
apiBridge.registerCustomHook(function(bindingsAPI) {
var apiFunctions = bindingsAPI.apiFunctions;
apiFunctions.setUpdateArgumentsPreValidate('setDefaultSuggestion',
function(suggestResult) {
if (suggestResult.content != undefined) { // null, etc.
throw new Error(
'setDefaultSuggestion cannot contain the "content" field');
}
return [suggestResult];
});
apiFunctions.setUpdateArgumentsPreValidate(
'setDefaultSuggestion', function(suggestResult) {
if (suggestResult.content != null) {
throw new Error(
'setDefaultSuggestion cannot contain the "content" field');
}
return [suggestResult];
});
apiFunctions.setHandleRequest('setDefaultSuggestion', function(details) {
var parseResult = parseOmniboxDescription(details.description);
......
......@@ -11,7 +11,7 @@ var normalizeAlgorithm =
// Any unknown parameters will be ignored.
function normalizeImportParams(importParams) {
if (!importParams.name ||
Object.prototype.toString.call(importParams.name) != '[object String]') {
Object.prototype.toString.call(importParams.name) !== '[object String]') {
throw new Error('Algorithm: name: Missing or not a String');
}
......
......@@ -42,7 +42,7 @@ function CreateOperationError() {
// returns true.
function catchInvalidTokenError(reject) {
if (bindingUtil.hasLastError() &&
chrome.runtime.lastError.message == errorInvalidToken) {
chrome.runtime.lastError.message === errorInvalidToken) {
var error = chrome.runtime.lastError;
bindingUtil.clearLastError();
reject(error);
......@@ -65,7 +65,7 @@ $Object.setPrototypeOf(SubtleCryptoImpl.prototype, null);
SubtleCryptoImpl.prototype.sign = function(algorithm, key, dataView) {
var subtleCrypto = this;
return new Promise(function(resolve, reject) {
if (key.type != 'private' || key.usages.indexOf(KeyUsage.sign) == -1)
if (key.type !== 'private' || key.usages.indexOf(KeyUsage.sign) === -1)
throw CreateInvalidAccessError();
var normalizedAlgorithmParameters =
......@@ -99,12 +99,12 @@ SubtleCryptoImpl.prototype.sign = function(algorithm, key, dataView) {
SubtleCryptoImpl.prototype.exportKey = function(format, key) {
return new Promise(function(resolve, reject) {
if (format == 'pkcs8') {
if (format === 'pkcs8') {
// Either key.type is not 'private' or the key is not extractable. In both
// cases the error is the same.
throw CreateInvalidAccessError();
} else if (format == 'spki') {
if (key.type != 'public')
} else if (format === 'spki') {
if (key.type !== 'public')
throw CreateInvalidAccessError();
resolve(getSpki(key));
} else {
......
......@@ -94,7 +94,7 @@ bindingUtil.registerEventArgumentMassager('syncFileSystem.onFileStatusChanged',
var fileInfo = new Object();
fileInfo.fileEntry = fileEntry;
fileInfo.status = args[1];
if (fileInfo.status == "synced") {
if (fileInfo.status === 'synced') {
fileInfo.action = args[2];
fileInfo.direction = args[3];
}
......
......@@ -21,7 +21,7 @@ apiBridge.registerCustomHook(function(bindingsAPI, extensionId) {
// Convenience function for processing webkitGetUserMedia() error objects to
// provide runtime.lastError messages for the tab capture API.
function getErrorMessage(error, fallbackMessage) {
if (!error || (typeof error.message != 'string'))
if (!error || (typeof error.message !== 'string'))
return fallbackMessage;
return error.message.replace(/(navigator\.)?(webkit)?GetUserMedia/gi,
name);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment