Commit ed487231 authored by Xianzhu Wang's avatar Xianzhu Wang Committed by Commit Bot

Explicitly enable SubresourceWebBundles for web tests

This CL (temporarily) explicitly enables SubresourceWebBundles for web
tests. Two tests under webexposed/ are rebaselined.
virtual/subresource-web-bundles is removed.

This is to seperate the change of web test expectations from
crrev.com/c/2375886 which will enable the feature for web tests by
adjusting the application order of blink feature status and chromium
feature status.

Bug: 1121839
Change-Id: I21da03bc90e456fbf606056f03351dd5f72e2161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378711Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: default avatarHayato Ito <hayato@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802109}
parent cd648bbc
...@@ -556,7 +556,8 @@ void SetRuntimeFeaturesFromFieldTrialParams() { ...@@ -556,7 +556,8 @@ void SetRuntimeFeaturesFromFieldTrialParams() {
// as a last resort. // as a last resort.
void SetCustomizedRuntimeFeaturesFromCombinedArgs( void SetCustomizedRuntimeFeaturesFromCombinedArgs(
const base::CommandLine& command_line, const base::CommandLine& command_line,
bool enable_experimental_web_platform_features) { bool enable_experimental_web_platform_features,
bool enable_blink_test_features) {
// CAUTION: Only add custom enabling logic here if it cannot // CAUTION: Only add custom enabling logic here if it cannot
// be covered by the other functions. // be covered by the other functions.
...@@ -605,6 +606,10 @@ void SetCustomizedRuntimeFeaturesFromCombinedArgs( ...@@ -605,6 +606,10 @@ void SetCustomizedRuntimeFeaturesFromCombinedArgs(
WebRuntimeFeatures::EnableNetInfoDownlinkMax(true); WebRuntimeFeatures::EnableNetInfoDownlinkMax(true);
} }
if (enable_blink_test_features) {
WebRuntimeFeatures::EnableSubresourceWebBundles(true);
}
// Except for stable release mode, web tests still run with Web Components // Except for stable release mode, web tests still run with Web Components
// v0 features enabled. // v0 features enabled.
// TODO(crbug.com/937746): remove this once the features are deleted. // TODO(crbug.com/937746): remove this once the features are deleted.
...@@ -672,8 +677,10 @@ void SetRuntimeFeaturesDefaultsAndUpdateFromArgs( ...@@ -672,8 +677,10 @@ void SetRuntimeFeaturesDefaultsAndUpdateFromArgs(
// Sets experimental features. // Sets experimental features.
bool enable_experimental_web_platform_features = bool enable_experimental_web_platform_features =
command_line.HasSwitch(switches::kEnableExperimentalWebPlatformFeatures); command_line.HasSwitch(switches::kEnableExperimentalWebPlatformFeatures);
bool enable_blink_test_features =
command_line.HasSwitch(switches::kEnableBlinkTestFeatures);
if (command_line.HasSwitch(switches::kEnableBlinkTestFeatures)) { if (enable_blink_test_features) {
enable_experimental_web_platform_features = true; enable_experimental_web_platform_features = true;
WebRuntimeFeatures::EnableTestOnlyFeatures(true); WebRuntimeFeatures::EnableTestOnlyFeatures(true);
} }
...@@ -705,7 +712,8 @@ void SetRuntimeFeaturesDefaultsAndUpdateFromArgs( ...@@ -705,7 +712,8 @@ void SetRuntimeFeaturesDefaultsAndUpdateFromArgs(
SetRuntimeFeaturesFromFieldTrialParams(); SetRuntimeFeaturesFromFieldTrialParams();
SetCustomizedRuntimeFeaturesFromCombinedArgs( SetCustomizedRuntimeFeaturesFromCombinedArgs(
command_line, enable_experimental_web_platform_features); command_line, enable_experimental_web_platform_features,
enable_blink_test_features);
// Enable explicitly enabled features, and then disable explicitly disabled // Enable explicitly enabled features, and then disable explicitly disabled
// ones. // ones.
......
...@@ -1794,7 +1794,7 @@ ...@@ -1794,7 +1794,7 @@
name: "SubresourceWebBundles", name: "SubresourceWebBundles",
origin_trial_feature_name: "SubresourceWebBundles", origin_trial_feature_name: "SubresourceWebBundles",
origin_trial_allows_third_party: true, origin_trial_allows_third_party: true,
status: "experimental" status: "test"
}, },
{ {
name: "SurfaceEmbeddingFeatures", name: "SurfaceEmbeddingFeatures",
......
...@@ -2145,10 +2145,6 @@ virtual/passive-fingerprinting/http/tests/navigation/frozen-useragent.html [ Pas ...@@ -2145,10 +2145,6 @@ virtual/passive-fingerprinting/http/tests/navigation/frozen-useragent.html [ Pas
# This test run under virtual suites only. # This test run under virtual suites only.
crbug.com/1018640 external/wpt/web-bundle/wbn-from-network/* [ Skip ] crbug.com/1018640 external/wpt/web-bundle/wbn-from-network/* [ Skip ]
virtual/wbn-from-network/external/wpt/web-bundle/wbn-from-network/* [ Pass ] virtual/wbn-from-network/external/wpt/web-bundle/wbn-from-network/* [ Pass ]
crbug.com/1082020 external/wpt/web-bundle/subresource-loading/* [ Skip ]
virtual/subresource-web-bundles/external/wpt/web-bundle/subresource-loading/* [ Pass ]
crbug.com/1082020 http/tests/loading/wbn/subresource-loading/* [ Skip ]
virtual/subresource-web-bundles/http/tests/loading/wbn/subresource-loading/* [ Pass ]
crbug.com/1082020 http/tests/loading/wbn/origin-trial/* [ Skip ] crbug.com/1082020 http/tests/loading/wbn/origin-trial/* [ Skip ]
virtual/subresource-web-bundles-disabled/http/tests/loading/wbn/origin-trial/* [ Pass ] virtual/subresource-web-bundles-disabled/http/tests/loading/wbn/origin-trial/* [ Pass ]
......
...@@ -723,12 +723,6 @@ ...@@ -723,12 +723,6 @@
"bases": [ "external/wpt/content-security-policy/embedded-enforcement" ], "bases": [ "external/wpt/content-security-policy/embedded-enforcement" ],
"args": [ "--enable-features=OutOfBlinkCSPEE" ] "args": [ "--enable-features=OutOfBlinkCSPEE" ]
}, },
{
"prefix": "subresource-web-bundles",
"bases": [ "external/wpt/web-bundle/subresource-loading",
"http/tests/loading/wbn/subresource-loading" ],
"args": [ "--enable-blink-features=SubresourceWebBundles" ]
},
{ {
"prefix": "subresource-web-bundles-disabled", "prefix": "subresource-web-bundles-disabled",
"bases": [ "http/tests/loading/wbn/origin-trial/" ], "bases": [ "http/tests/loading/wbn/origin-trial/" ],
......
This directory is for testing the SubresourceWebBundles feature.
...@@ -790,6 +790,7 @@ html element link ...@@ -790,6 +790,7 @@ html element link
property referrerPolicy property referrerPolicy
property rel property rel
property relList property relList
property resources
property rev property rev
property sheet property sheet
property sizes property sizes
......
...@@ -3623,6 +3623,7 @@ interface HTMLLinkElement : HTMLElement ...@@ -3623,6 +3623,7 @@ interface HTMLLinkElement : HTMLElement
getter referrerPolicy getter referrerPolicy
getter rel getter rel
getter relList getter relList
getter resources
getter rev getter rev
getter sheet getter sheet
getter sizes getter sizes
...@@ -3643,6 +3644,7 @@ interface HTMLLinkElement : HTMLElement ...@@ -3643,6 +3644,7 @@ interface HTMLLinkElement : HTMLElement
setter referrerPolicy setter referrerPolicy
setter rel setter rel
setter relList setter relList
setter resources
setter rev setter rev
setter sizes setter sizes
setter target setter target
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment