Commit eda4c3ea authored by Justin Cohen's avatar Justin Cohen Committed by Commit Bot

[ios] Speed up egtest failures by skipping _recordFailure.

_recordFailure internally spends a very long time symbolicating
on iOS13. Skipping this seems to be safe.

Bug:991338

Change-Id: I74c2872cd82de0840a6bcdd0f799703b5eb9bdb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725137Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684557}
parent cabab806
...@@ -104,6 +104,12 @@ UIDeviceOrientation GetCurrentDeviceOrientation() { ...@@ -104,6 +104,12 @@ UIDeviceOrientation GetCurrentDeviceOrientation() {
} // namespace } // namespace
// Category for overriding private methods on XCTestCase. See crbug.com/991338
// for more information.
@interface XCTestCase (Private)
- (void)_recordFailure:(id)arg1;
@end
#if defined(CHROME_EARL_GREY_2) #if defined(CHROME_EARL_GREY_2)
GREY_STUB_CLASS_IN_APP_MAIN_QUEUE(ChromeTestCaseAppInterface) GREY_STUB_CLASS_IN_APP_MAIN_QUEUE(ChromeTestCaseAppInterface)
#endif #endif
...@@ -180,6 +186,16 @@ GREY_STUB_CLASS_IN_APP_MAIN_QUEUE(ChromeTestCaseAppInterface) ...@@ -180,6 +186,16 @@ GREY_STUB_CLASS_IN_APP_MAIN_QUEUE(ChromeTestCaseAppInterface)
} }
} }
- (void)_recordFailure:(id)arg1 {
if (@available(iOS 13, *)) {
// _recordFailure internally spends a very long time symbolicating
// on iOS13. Skipping this seems to be safe. See crbug.com/991338
// for more information.
} else {
[super _recordFailure:arg1];
}
}
#if defined(CHROME_EARL_GREY_1) #if defined(CHROME_EARL_GREY_1)
+ (void)setUp { + (void)setUp {
[super setUp]; [super setUp];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment