Commit eda7fea0 authored by Vlad Tsyrklevich's avatar Vlad Tsyrklevich Committed by Commit Bot

GWP-ASan: Limit when Android is enabled

Limit when Android is enabled to when enable_frame_pointers=true.
Android doesn't ship unwind tables by default, so otherwise it can't
unwind and save alloc/dealloc stack traces. At the moment this is only
for AArch64 builds which we don't yet ship.

Bug: 973167
Change-Id: I4fe126394819e24875eccc856a0f8ef5cf8a844c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841187Reviewed-by: default avatarVitaly Buka <vitalybuka@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703127}
parent 1420feeb
......@@ -4,11 +4,15 @@
import("//base/allocator/allocator.gni")
import("//build/config/allocator.gni")
import("//build/config/compiler/compiler.gni")
# Windows/x86 is disabled due to https://crbug.com/969146
# Android component builds are disabled due to https://crbug.com/976399
supported_platform = is_mac || (is_win && current_cpu == "x64") ||
(is_android && !is_component_build)
# Android requires frame pointers for unwinding, unwind tables aren't shipped in
# official builds.
supported_platform =
is_mac || (is_win && current_cpu == "x64") ||
(is_android && !is_component_build && enable_frame_pointers)
declare_args() {
# Is GWP-ASan malloc/PartitionAlloc hooking enabled for chrome/ on a given
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment