Commit edadf153 authored by yusufo@chromium.org's avatar yusufo@chromium.org

Add gestureFlingStart to gestures that can cancel a deferred tapDown

It looks like there are cases where we might get a tapDown followed by a flingStart
immediately without and scrollBegin from the Android framework. To avoid using the
tapDown in these situations have flingStart also remove the deferred tapDown like
scrollBegin and pinchBegin

BUG=135818


Review URL: https://chromiumcodereview.appspot.com/11418218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170583 0039d316-1c4b-4281-b951-d872f2087c98
parent b96a1d1a
...@@ -136,10 +136,6 @@ bool GestureEventFilter::ShouldForwardForTapDeferral( ...@@ -136,10 +136,6 @@ bool GestureEventFilter::ShouldForwardForTapDeferral(
return ShouldHandleEventNow(); return ShouldHandleEventNow();
} }
return false; return false;
case WebInputEvent::GestureFlingStart:
fling_in_progress_ = true;
coalesced_gesture_events_.push_back(gesture_event);
return ShouldHandleEventNow();
case WebInputEvent::GestureTapDown: case WebInputEvent::GestureTapDown:
// GestureTapDown is always paired with either a Tap, DoubleTap, LongPress // GestureTapDown is always paired with either a Tap, DoubleTap, LongPress
// or TapCancel, so it should be impossible to have more than one // or TapCancel, so it should be impossible to have more than one
...@@ -177,6 +173,8 @@ bool GestureEventFilter::ShouldForwardForTapDeferral( ...@@ -177,6 +173,8 @@ bool GestureEventFilter::ShouldForwardForTapDeferral(
} }
coalesced_gesture_events_.push_back(gesture_event); coalesced_gesture_events_.push_back(gesture_event);
return ShouldHandleEventNow(); return ShouldHandleEventNow();
case WebInputEvent::GestureFlingStart:
fling_in_progress_ = true;
case WebInputEvent::GestureScrollBegin: case WebInputEvent::GestureScrollBegin:
case WebInputEvent::GesturePinchBegin: case WebInputEvent::GesturePinchBegin:
send_gtd_timer_.Stop(); send_gtd_timer_.Stop();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment