Commit edc9e11e authored by Nate Fischer's avatar Nate Fischer Committed by Commit Bot

AW UMA: guard stability metrics behind a flag

This guards stability metrics behind kWebViewWakeMetricsService. While
not directly related, AwStabilityMetricsProvider has the same effect as
enabling this flag because it logs a "user action" for every page load.

This puts the entire metrics provider behind the off-by-default flag, to
avoid any accidental UMA volume increase until we've found a path
forward for launching that feature.

Bug: 1058684
Test: None
Change-Id: I0937a1d44aaf4d0c54dee8dfe4644c2216d77891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095196
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: default avatarTobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748333}
parent ffddc47c
...@@ -175,9 +175,11 @@ void AwMetricsServiceClient::OnAppStateChanged( ...@@ -175,9 +175,11 @@ void AwMetricsServiceClient::OnAppStateChanged(
void AwMetricsServiceClient::RegisterAdditionalMetricsProviders( void AwMetricsServiceClient::RegisterAdditionalMetricsProviders(
metrics::MetricsService* service) { metrics::MetricsService* service) {
service->RegisterMetricsProvider( if (base::FeatureList::IsEnabled(features::kWebViewWakeMetricsService)) {
std::make_unique<android_webview::AwStabilityMetricsProvider>( service->RegisterMetricsProvider(
pref_service())); std::make_unique<android_webview::AwStabilityMetricsProvider>(
pref_service()));
}
} }
// static // static
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment