Commit ede7a7ba authored by Guido Urdaneta's avatar Guido Urdaneta Committed by Commit Bot

Split dlerror() logging statement in generate_stubs.py

We are seeing cases where dlerror() crashes without a known reason
under MSAN in a logging statement of InitializeStubs() during
PulseAudio initialization.
This CL splits the logging statement that reports the library that
failed to open and the call to dlerror().
This will allow us to see in the logs which library failed to load prior
to the dlerror crash.


Bug: 1109346
Change-Id: I3adbdf27e7207404a0c4d8a9fd472b77a8932c8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332259
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794845}
parent e59a4fd0
...@@ -311,8 +311,8 @@ UMBRELLA_INITIALIZER_INITIALIZE_FUNCTION_START = ( ...@@ -311,8 +311,8 @@ UMBRELLA_INITIALIZER_INITIALIZE_FUNCTION_START = (
module_opened = true; module_opened = true;
opened_libraries[cur_module] = handle; opened_libraries[cur_module] = handle;
} else { } else {
%(logging_function)s << "dlopen(" << dso_path->c_str() << ") failed, " %(logging_function)s << "dlopen(" << dso_path->c_str() << ") failed.";
<< "dlerror() says:\\n" << dlerror(); %(logging_function)s << "dlerror() says:\\n" << dlerror();
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment