arc: remove flag for smart text selection.

This cl is just a cleanup of the now unused flag for smart text
selection.

Bug: 1110727
Test: This is non-op as the flag was removed from chrome://flags already
Change-Id: Ib04755ca7eefa42a0b320874cc99c6f08633ec00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437592
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: David Jacobo <djacobo@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811779}

chrome/browser/about_flags.cc

@@ -4648,12 +4648,6 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(features::kUseAAudioDriver)},
 #endif
 
-#if defined(OS_CHROMEOS)
-    {"smart-text-selection", flag_descriptions::kSmartTextSelectionName,
-     flag_descriptions::kSmartTextSelectionDescription, kOsCrOS,
-     FEATURE_VALUE_TYPE(arc::kSmartTextSelectionFeature)},
-#endif  // OS_CHROMEOS
-
     {"allow-sxg-certs-without-extension",
      flag_descriptions::kAllowSignedHTTPExchangeCertsWithoutExtensionName,
      flag_descriptions::

chrome/browser/chromeos/arc/intent_helper/start_smart_selection_action_menu.cc

@@ -17,7 +17,6 @@
 #include "chrome/browser/apps/app_service/app_icon_factory.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/grit/generated_resources.h"
-#include "components/arc/arc_features.h"
 #include "components/arc/arc_service_manager.h"
 #include "components/arc/intent_helper/arc_intent_helper_bridge.h"
 #include "components/arc/metrics/arc_metrics_constants.h"
@@ -44,9 +43,6 @@ StartSmartSelectionActionMenu::~StartSmartSelectionActionMenu() = default;
 
 void StartSmartSelectionActionMenu::InitMenu(
     const content::ContextMenuParams& params) {
-  if (!base::FeatureList::IsEnabled(kSmartTextSelectionFeature))
-    return;
-
   const std::string converted_text = base::UTF16ToUTF8(params.selection_text);
   if (converted_text.empty())
     return;

chrome/browser/flag_descriptions.cc

@@ -4294,11 +4294,6 @@ const char kSmartDimNewMlAgentDescription[] =
     "Uses a new machine learning agent to switch between builtin and dynamic "
     "ML models.";
 
-const char kSmartTextSelectionName[] = "Smart Text Selection";
-const char kSmartTextSelectionDescription[] =
-    "Shows quick actions for text "
-    "selections in the context menu.";
-
 const char kSmbfsFileSharesName[] = "Smbfs file shares";
 const char kSmbfsFileSharesDescription[] =
     "Use smbfs for accessing network file shares.";

chrome/browser/flag_descriptions.h

@@ -2501,9 +2501,6 @@ extern const char kSmartDimModelV3Description[];
 extern const char kSmartDimNewMlAgentName[];
 extern const char kSmartDimNewMlAgentDescription[];
 
-extern const char kSmartTextSelectionName[];
-extern const char kSmartTextSelectionDescription[];
-
 extern const char kSmbfsFileSharesName[];
 extern const char kSmbfsFileSharesDescription[];
 

chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -887,7 +887,6 @@ void RenderViewContextMenu::InitMenu() {
   bool supports_smart_text_selection = false;
 #if defined(OS_CHROMEOS)
   supports_smart_text_selection =
-      base::FeatureList::IsEnabled(arc::kSmartTextSelectionFeature) &&
       content_type_->SupportsGroup(
           ContextMenuContentType::ITEM_GROUP_SMART_SELECTION) &&
       arc::IsArcPlayStoreEnabledForProfile(GetProfile());

chrome/browser/ui/views/touch_selection_menu_runner_chromeos.cc

@@ -11,7 +11,6 @@
 #include "base/metrics/user_metrics_action.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/views/touch_selection_menu_chromeos.h"
-#include "components/arc/arc_features.h"
 #include "components/arc/arc_service_manager.h"
 #include "components/arc/session/arc_bridge_service.h"
 #include "ui/aura/window.h"
@@ -54,9 +53,6 @@ bool TouchSelectionMenuRunnerChromeOS::RequestTextSelection(
     const gfx::Rect& anchor_rect,
     const gfx::Size& handle_image_size,
     aura::Window* context) {
-  if (!base::FeatureList::IsEnabled(arc::kSmartTextSelectionFeature))
-    return false;
-
   const std::string converted_text =
       base::UTF16ToUTF8(client->GetSelectedText());
   if (converted_text.empty())

components/arc/arc_features.cc

@@ -73,12 +73,6 @@ const base::Feature kNativeBridgeToggleFeature{
 const base::Feature kPictureInPictureFeature{"ArcPictureInPicture",
                                              base::FEATURE_ENABLED_BY_DEFAULT};
 
-// Controls Smart Text Selection for Chrome.
-// When enabled, the context menu will show contextual quick actions based on
-// the current text selection.
-const base::Feature kSmartTextSelectionFeature{
-    "ArcSmartTextSelection", base::FEATURE_ENABLED_BY_DEFAULT};
-
 // Controls ARC USB host integration.
 // When enabled, Android apps will be able to use usb host features.
 const base::Feature kUsbHostFeature{"ArcUsbHost",

components/arc/arc_features.h

@@ -26,7 +26,6 @@ extern const base::Feature kFilePickerExperimentFeature;
 extern const base::Feature kNativeBridge64BitSupportExperimentFeature;
 extern const base::Feature kNativeBridgeToggleFeature;
 extern const base::Feature kPictureInPictureFeature;
-extern const base::Feature kSmartTextSelectionFeature;
 extern const base::Feature kUsbHostFeature;
 extern const base::Feature kUsbStorageUIFeature;
 extern const base::Feature kVideoDecoder;