Renamed LoadCommittedDetails.is_in_page to is_same_document.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2841833002
Cr-Commit-Position: refs/heads/master@{#467720}

chrome/browser/media_galleries/media_file_system_registry.cc

@@ -184,7 +184,7 @@ void RPHReferenceManager::RPHWebContentsObserver::WebContentsDestroyed() {
 
 void RPHReferenceManager::RPHWebContentsObserver::NavigationEntryCommitted(
     const content::LoadCommittedDetails& load_details) {
-  if (load_details.is_in_page)
+  if (load_details.is_same_document)
     return;
 
   manager_->OnWebContentsDestroyedOrNavigated(web_contents());

chrome/browser/supervised_user/supervised_user_interstitial.cc

@@ -157,7 +157,7 @@ bool SupervisedUserInterstitial::Init() {
     // Remove all the infobars which are attached to |web_contents_| and for
     // which ShouldExpire() returns true.
     content::LoadCommittedDetails details;
-    // |details.is_in_page| is default false, and |details.is_main_frame| is
+    // |details.is_same_page| is default false, and |details.is_main_frame| is
     // default true. This results in is_navigation_to_different_page() returning
     // true.
     DCHECK(details.is_navigation_to_different_page());

chrome/browser/ui/chrome_bubble_manager.cc

@@ -160,7 +160,7 @@ void ChromeBubbleManager::DidToggleFullscreenModeForTab(
 
 void ChromeBubbleManager::NavigationEntryCommitted(
     const content::LoadCommittedDetails& load_details) {
-  if (!load_details.is_in_page)
+  if (!load_details.is_same_document)
     CloseAllBubbles(BUBBLE_CLOSE_NAVIGATED);
 }
 

content/browser/frame_host/navigation_controller_impl.cc

@@ -844,8 +844,8 @@ bool NavigationControllerImpl::RendererDidNavigate(
   // Do navigation-type specific actions. These will make and commit an entry.
   details->type = ClassifyNavigation(rfh, params);
 
-  // is_in_page must be computed before the entry gets committed.
-  details->is_in_page = is_navigation_within_page;
+  // is_same_document must be computed before the entry gets committed.
+  details->is_same_document = is_navigation_within_page;
 
   // Save reload type and timestamp for a reload navigation to detect
   // consecutive reloads when the next reload is requested.
@@ -863,20 +863,20 @@ bool NavigationControllerImpl::RendererDidNavigate(
 
   switch (details->type) {
     case NAVIGATION_TYPE_NEW_PAGE:
-      RendererDidNavigateToNewPage(rfh, params, details->is_in_page,
+      RendererDidNavigateToNewPage(rfh, params, details->is_same_document,
                                    details->did_replace_entry,
                                    navigation_handle);
       break;
     case NAVIGATION_TYPE_EXISTING_PAGE:
-      details->did_replace_entry = details->is_in_page;
-      RendererDidNavigateToExistingPage(rfh, params, details->is_in_page,
+      details->did_replace_entry = details->is_same_document;
+      RendererDidNavigateToExistingPage(rfh, params, details->is_same_document,
                                         was_restored, navigation_handle);
       break;
     case NAVIGATION_TYPE_SAME_PAGE:
       RendererDidNavigateToSamePage(rfh, params, navigation_handle);
       break;
     case NAVIGATION_TYPE_NEW_SUBFRAME:
-      RendererDidNavigateNewSubframe(rfh, params, details->is_in_page,
+      RendererDidNavigateNewSubframe(rfh, params, details->is_same_document,
                                      details->did_replace_entry);
       break;
     case NAVIGATION_TYPE_AUTO_SUBFRAME:

content/browser/web_contents/web_contents_impl.cc

@@ -3619,7 +3619,7 @@ void WebContentsImpl::DidNavigateAnyFramePostCommit(
   has_accessed_initial_document_ = false;
 
   // If we navigate off the page, close all JavaScript dialogs.
-  if (!details.is_in_page)
+  if (!details.is_same_document)
     CancelActiveAndPendingDialogs();
 
   // If this is a user-initiated navigation, start allowing JavaScript dialogs

content/public/browser/navigation_details.cc

@@ -11,10 +11,9 @@ LoadCommittedDetails::LoadCommittedDetails()
       type(content::NAVIGATION_TYPE_UNKNOWN),
       previous_entry_index(-1),
       did_replace_entry(false),
-      is_in_page(false),
+      is_same_document(false),
       is_main_frame(true),
-      http_status_code(0) {
-}
+      http_status_code(0) {}
 
 LoadCommittedDetails::LoadCommittedDetails(const LoadCommittedDetails& other) =
     default;

content/public/browser/navigation_details.h

@@ -43,9 +43,12 @@ struct CONTENT_EXPORT LoadCommittedDetails {
   // A non-user initiated redirect causes such replacement.
   bool did_replace_entry;
 
-  // True if the navigation was in-page. This means that the active entry's
-  // URL and the |previous_url| are the same except for reference fragments.
-  bool is_in_page;
+  // Whether the navigation happened without changing document. Examples of
+  // same document navigations are:
+  // * reference fragment navigations
+  // * pushState/replaceState
+  // * same page history navigation
+  bool is_same_document;
 
   // True when the main frame was navigated. False means the navigation was a
   // sub-frame.
@@ -55,7 +58,7 @@ struct CONTENT_EXPORT LoadCommittedDetails {
   // scrolling to a fragment inside the current page). We often need this logic
   // for showing or hiding something.
   bool is_navigation_to_different_page() const {
-    return is_main_frame && !is_in_page;
+    return is_main_frame && !is_same_document;
   }
 
   // The HTTP status code for this entry..

services/navigation/view_impl.cc

@@ -240,7 +240,7 @@ void ViewImpl::Observe(int type,
       details_ptr->type = static_cast<mojom::NavigationType>(lcd->type);
       details_ptr->previous_entry_index = lcd->previous_entry_index;
       details_ptr->previous_url = lcd->previous_url;
-      details_ptr->is_in_page = lcd->is_in_page;
+      details_ptr->is_in_page = lcd->is_same_document;
       details_ptr->is_main_frame = lcd->is_main_frame;
       details_ptr->http_status_code = lcd->http_status_code;
       client_->NavigationCommitted(