Commit ee170e51 authored by Sami Kyostila's avatar Sami Kyostila Committed by Chromium LUCI CQ

ui/gl: Add missing semicolons to TRACE_EVENTs

Chrome is about to switch to the TRACE_EVENT macro implementation
provided by Perfetto. The new implementation requires trace event
statements to be terminated by semicolons, so this patch modifies the
codebase to add semicolons where they were previously left out.

No functional changes.

Bug: 1006541
Change-Id: I2fffe5a69d13fec291795466da84d143c6d56005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629708
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: default avatarSunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844923}
parent f8f4fd67
...@@ -3418,7 +3418,7 @@ void DriverEGL::InitializeExtensionBindings() { ...@@ -3418,7 +3418,7 @@ void DriverEGL::InitializeExtensionBindings() {
file.write('%s Trace%sApi::%sFn(%s) {\n' % file.write('%s Trace%sApi::%sFn(%s) {\n' %
(return_type, set_name.upper(), function_name, arguments)) (return_type, set_name.upper(), function_name, arguments))
argument_names = MakeArgNames(arguments) argument_names = MakeArgNames(arguments)
file.write(' TRACE_EVENT_BINARY_EFFICIENT0("gpu", "Trace%sAPI::%s")\n' % file.write(' TRACE_EVENT_BINARY_EFFICIENT0("gpu", "Trace%sAPI::%s");\n' %
(set_name.upper(), function_name)) (set_name.upper(), function_name))
if return_type == 'void': if return_type == 'void':
file.write(' %s_api_->%sFn(%s);\n' % file.write(' %s_api_->%sFn(%s);\n' %
......
This diff is collapsed.
This source diff could not be displayed because it is too large. You can view the blob instead.
This diff is collapsed.
...@@ -169,13 +169,13 @@ GrGLFunction<R GR_GL_FUNCTION_TYPE(Args...)> bind_with_flush_on_mac( ...@@ -169,13 +169,13 @@ GrGLFunction<R GR_GL_FUNCTION_TYPE(Args...)> bind_with_flush_on_mac(
base::mac::GetCPUType() == base::mac::CPUType::kIntel; base::mac::GetCPUType() == base::mac::CPUType::kIntel;
if (needs_flush) { if (needs_flush) {
TRACE_EVENT0( TRACE_EVENT0(
"gpu", "CreateGrGLInterface - bind_with_flush_on_mac - beforefunc") "gpu", "CreateGrGLInterface - bind_with_flush_on_mac - beforefunc");
glFlush(); glFlush();
} }
func(args...); func(args...);
if (needs_flush) { if (needs_flush) {
TRACE_EVENT0("gpu", TRACE_EVENT0(
"CreateGrGLInterface - bind_with_flush_on_mac - afterfunc") "gpu", "CreateGrGLInterface - bind_with_flush_on_mac - afterfunc");
glFlush(); glFlush();
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment