Commit ee5e9d98 authored by rtenneti@chromium.org's avatar rtenneti@chromium.org

QUIC - minor clean up of comments per wtc' comments for the CL:

https://codereview.chromium.org/288313003/

R=wtc@chromium.org

Review URL: https://codereview.chromium.org/292113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271751 0039d316-1c4b-4281-b951-d872f2087c98
parent 53c7e6f1
......@@ -22,7 +22,6 @@
#include "net/socket/socket_test_util.h"
#include "net/udp/datagram_client_socket.h"
using net::test::kInitialFlowControlWindowForTest;
using testing::_;
namespace net {
......
......@@ -93,9 +93,9 @@ class NET_EXPORT_PRIVATE QuicConnectionVisitorInterface {
// Called when a blocked socket becomes writable.
virtual void OnCanWrite() = 0;
// Called to ask if the visitor wants to schedule write resumption as it has
// both has pending data to write, and is able to write (e.g. based on flow
// control limits).
// Called to ask if the visitor wants to schedule write resumption as it both
// has pending data to write, and is able to write (e.g. based on flow control
// limits).
// Writes may be pending because they were write-blocked, congestion-throttled
// or yielded to other connections.
virtual bool WillingAndAbleToWrite() const = 0;
......
......@@ -57,9 +57,9 @@ class NET_EXPORT_PRIVATE QuicPacketCreator : public QuicFecBuilderInterface {
virtual void OnBuiltFecProtectedPayload(const QuicPacketHeader& header,
base::StringPiece payload) OVERRIDE;
// Turn on FEC protection for subsequently created packets. FEC should
// be enabled first (set_max_packets_per_fec_group should be non-zero) for
// FEC protection to start.
// Turn on FEC protection for subsequently created packets. FEC should be
// enabled first (max_packets_per_fec_group should be non-zero) for FEC
// protection to start.
void StartFecProtectingPackets();
// Turn off FEC protection for subsequently created packets. If the creator
......@@ -126,7 +126,7 @@ class NET_EXPORT_PRIVATE QuicPacketCreator : public QuicFecBuilderInterface {
// Re-serializes frames with the original packet's sequence number length.
// Used for retransmitting packets to ensure they aren't too long.
// Caller must ensure that any open FEC group are closed before calling this
// Caller must ensure that any open FEC group is closed before calling this
// method.
SerializedPacket ReserializeAllFrames(
const QuicFrames& frames, QuicSequenceNumberLength original_length);
......@@ -136,7 +136,7 @@ class NET_EXPORT_PRIVATE QuicPacketCreator : public QuicFecBuilderInterface {
// Returns whether FEC protection is currently enabled. Note: Enabled does not
// mean that an FEC group is currently active; i.e., IsFecProtected() may
// still return NOT_IN_FEC_GROUP, and fec_group_.get() may still be NULL.
// still return false.
bool IsFecEnabled() const;
// Returns true if subsequent packets will be FEC protected. Note: True does
......
......@@ -173,8 +173,8 @@ void QuicSentPacketManager::HandleAckForSentPackets(
}
if (IsAwaitingPacket(received_info, sequence_number)) {
// Remove any packets not being tracked by the send algorithm, allowing
// the high water mark to be raised if necessary.
// Remove any rtt only packets less than or equal to the largest observed,
// since they will not produce an RTT measurement.
if (QuicUnackedPacketMap::IsForRttOnly(it->second)) {
it = MarkPacketHandled(sequence_number, delta_largest_observed);
} else {
......
......@@ -114,7 +114,7 @@ class StreamBlocker {
class TestSession : public QuicSession {
public:
explicit TestSession(QuicConnection* connection,
TestSession(QuicConnection* connection,
uint32 max_initial_flow_control_window)
: QuicSession(connection, max_initial_flow_control_window,
DefaultQuicConfig()),
......
......@@ -17,8 +17,8 @@
using net::test::DefaultQuicConfig;
using net::test::SupportedVersions;
using testing::TestWithParam;
using testing::StrictMock;
using testing::TestWithParam;
namespace net {
namespace tools {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment