Commit ee5e9d98 authored by rtenneti@chromium.org's avatar rtenneti@chromium.org

QUIC - minor clean up of comments per wtc' comments for the CL:

https://codereview.chromium.org/288313003/

R=wtc@chromium.org

Review URL: https://codereview.chromium.org/292113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271751 0039d316-1c4b-4281-b951-d872f2087c98
parent 53c7e6f1
...@@ -22,7 +22,6 @@ ...@@ -22,7 +22,6 @@
#include "net/socket/socket_test_util.h" #include "net/socket/socket_test_util.h"
#include "net/udp/datagram_client_socket.h" #include "net/udp/datagram_client_socket.h"
using net::test::kInitialFlowControlWindowForTest;
using testing::_; using testing::_;
namespace net { namespace net {
......
...@@ -93,9 +93,9 @@ class NET_EXPORT_PRIVATE QuicConnectionVisitorInterface { ...@@ -93,9 +93,9 @@ class NET_EXPORT_PRIVATE QuicConnectionVisitorInterface {
// Called when a blocked socket becomes writable. // Called when a blocked socket becomes writable.
virtual void OnCanWrite() = 0; virtual void OnCanWrite() = 0;
// Called to ask if the visitor wants to schedule write resumption as it has // Called to ask if the visitor wants to schedule write resumption as it both
// both has pending data to write, and is able to write (e.g. based on flow // has pending data to write, and is able to write (e.g. based on flow control
// control limits). // limits).
// Writes may be pending because they were write-blocked, congestion-throttled // Writes may be pending because they were write-blocked, congestion-throttled
// or yielded to other connections. // or yielded to other connections.
virtual bool WillingAndAbleToWrite() const = 0; virtual bool WillingAndAbleToWrite() const = 0;
......
...@@ -57,9 +57,9 @@ class NET_EXPORT_PRIVATE QuicPacketCreator : public QuicFecBuilderInterface { ...@@ -57,9 +57,9 @@ class NET_EXPORT_PRIVATE QuicPacketCreator : public QuicFecBuilderInterface {
virtual void OnBuiltFecProtectedPayload(const QuicPacketHeader& header, virtual void OnBuiltFecProtectedPayload(const QuicPacketHeader& header,
base::StringPiece payload) OVERRIDE; base::StringPiece payload) OVERRIDE;
// Turn on FEC protection for subsequently created packets. FEC should // Turn on FEC protection for subsequently created packets. FEC should be
// be enabled first (set_max_packets_per_fec_group should be non-zero) for // enabled first (max_packets_per_fec_group should be non-zero) for FEC
// FEC protection to start. // protection to start.
void StartFecProtectingPackets(); void StartFecProtectingPackets();
// Turn off FEC protection for subsequently created packets. If the creator // Turn off FEC protection for subsequently created packets. If the creator
...@@ -126,7 +126,7 @@ class NET_EXPORT_PRIVATE QuicPacketCreator : public QuicFecBuilderInterface { ...@@ -126,7 +126,7 @@ class NET_EXPORT_PRIVATE QuicPacketCreator : public QuicFecBuilderInterface {
// Re-serializes frames with the original packet's sequence number length. // Re-serializes frames with the original packet's sequence number length.
// Used for retransmitting packets to ensure they aren't too long. // Used for retransmitting packets to ensure they aren't too long.
// Caller must ensure that any open FEC group are closed before calling this // Caller must ensure that any open FEC group is closed before calling this
// method. // method.
SerializedPacket ReserializeAllFrames( SerializedPacket ReserializeAllFrames(
const QuicFrames& frames, QuicSequenceNumberLength original_length); const QuicFrames& frames, QuicSequenceNumberLength original_length);
...@@ -136,7 +136,7 @@ class NET_EXPORT_PRIVATE QuicPacketCreator : public QuicFecBuilderInterface { ...@@ -136,7 +136,7 @@ class NET_EXPORT_PRIVATE QuicPacketCreator : public QuicFecBuilderInterface {
// Returns whether FEC protection is currently enabled. Note: Enabled does not // Returns whether FEC protection is currently enabled. Note: Enabled does not
// mean that an FEC group is currently active; i.e., IsFecProtected() may // mean that an FEC group is currently active; i.e., IsFecProtected() may
// still return NOT_IN_FEC_GROUP, and fec_group_.get() may still be NULL. // still return false.
bool IsFecEnabled() const; bool IsFecEnabled() const;
// Returns true if subsequent packets will be FEC protected. Note: True does // Returns true if subsequent packets will be FEC protected. Note: True does
......
...@@ -173,8 +173,8 @@ void QuicSentPacketManager::HandleAckForSentPackets( ...@@ -173,8 +173,8 @@ void QuicSentPacketManager::HandleAckForSentPackets(
} }
if (IsAwaitingPacket(received_info, sequence_number)) { if (IsAwaitingPacket(received_info, sequence_number)) {
// Remove any packets not being tracked by the send algorithm, allowing // Remove any rtt only packets less than or equal to the largest observed,
// the high water mark to be raised if necessary. // since they will not produce an RTT measurement.
if (QuicUnackedPacketMap::IsForRttOnly(it->second)) { if (QuicUnackedPacketMap::IsForRttOnly(it->second)) {
it = MarkPacketHandled(sequence_number, delta_largest_observed); it = MarkPacketHandled(sequence_number, delta_largest_observed);
} else { } else {
......
...@@ -114,8 +114,8 @@ class StreamBlocker { ...@@ -114,8 +114,8 @@ class StreamBlocker {
class TestSession : public QuicSession { class TestSession : public QuicSession {
public: public:
explicit TestSession(QuicConnection* connection, TestSession(QuicConnection* connection,
uint32 max_initial_flow_control_window) uint32 max_initial_flow_control_window)
: QuicSession(connection, max_initial_flow_control_window, : QuicSession(connection, max_initial_flow_control_window,
DefaultQuicConfig()), DefaultQuicConfig()),
crypto_stream_(this), crypto_stream_(this),
......
...@@ -17,8 +17,8 @@ ...@@ -17,8 +17,8 @@
using net::test::DefaultQuicConfig; using net::test::DefaultQuicConfig;
using net::test::SupportedVersions; using net::test::SupportedVersions;
using testing::TestWithParam;
using testing::StrictMock; using testing::StrictMock;
using testing::TestWithParam;
namespace net { namespace net {
namespace tools { namespace tools {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment