Commit ee5f0d37 authored by Matt Falkenhagen's avatar Matt Falkenhagen Committed by Commit Bot

history service: Turn DCHECKs to CHECKs to try to diagnose crash bug.

Bug: 1009795
Change-Id: Ib33c1242228e674442f21dea8a56ef456d84b886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899231Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712948}
parent ab94bc19
...@@ -491,8 +491,10 @@ base::CancelableTaskTracker::TaskId HistoryService::GetFaviconsForURL( ...@@ -491,8 +491,10 @@ base::CancelableTaskTracker::TaskId HistoryService::GetFaviconsForURL(
favicon_base::FaviconResultsCallback callback, favicon_base::FaviconResultsCallback callback,
base::CancelableTaskTracker* tracker) { base::CancelableTaskTracker* tracker) {
TRACE_EVENT0("browser", "HistoryService::GetFaviconsForURL"); TRACE_EVENT0("browser", "HistoryService::GetFaviconsForURL");
DCHECK(backend_task_runner_) << "History service being called after cleanup"; // TODO(crbug.com/1009795): Return the CHECKs to DCHECKs after the bug is
DCHECK(thread_checker_.CalledOnValidThread()); // fixed.
CHECK(thread_checker_.CalledOnValidThread());
CHECK(backend_task_runner_) << "History service being called after cleanup";
return tracker->PostTaskAndReplyWithResult( return tracker->PostTaskAndReplyWithResult(
backend_task_runner_.get(), FROM_HERE, backend_task_runner_.get(), FROM_HERE,
base::BindOnce(&HistoryBackend::GetFaviconsForURL, history_backend_, base::BindOnce(&HistoryBackend::GetFaviconsForURL, history_backend_,
...@@ -640,8 +642,10 @@ void HistoryService::SetOnDemandFavicons( ...@@ -640,8 +642,10 @@ void HistoryService::SetOnDemandFavicons(
const GURL& icon_url, const GURL& icon_url,
const std::vector<SkBitmap>& bitmaps, const std::vector<SkBitmap>& bitmaps,
base::OnceCallback<void(bool)> callback) { base::OnceCallback<void(bool)> callback) {
DCHECK(backend_task_runner_) << "History service being called after cleanup"; // TODO(crbug.com/1009795): Return the CHECKs to DCHECKs after the bug is
DCHECK(thread_checker_.CalledOnValidThread()); // fixed.
CHECK(thread_checker_.CalledOnValidThread());
CHECK(backend_task_runner_) << "History service being called after cleanup";
if (history_client_ && !history_client_->CanAddURL(page_url)) { if (history_client_ && !history_client_->CanAddURL(page_url)) {
std::move(callback).Run(false); std::move(callback).Run(false);
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment