Commit ee6c75e0 authored by Rune Lillesveen's avatar Rune Lillesveen Committed by Commit Bot

Make CSSRule.PROPERTY_RULE = 18 as per spec.

https://drafts.css-houdini.org/css-properties-values-api/#extensions-to-css-rule-interface

Bug: 1008886
Change-Id: Ie587ec75864b856b2c020ba28ce209718c772c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875256Reviewed-by: default avatarXiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708575}
parent 7c7fc5c9
...@@ -56,11 +56,9 @@ class CORE_EXPORT CSSRule : public ScriptWrappable { ...@@ -56,11 +56,9 @@ class CORE_EXPORT CSSRule : public ScriptWrappable {
kNamespaceRule = 10, kNamespaceRule = 10,
kSupportsRule = 12, kSupportsRule = 12,
kViewportRule = 15, kViewportRule = 15,
kPropertyRule = 18,
// Experimental features below. Such features must be greater than 1000: // Experimental features below. Such features must be greater than 1000:
// the 0-1000 range is reserved by the CSS Working Group. // the 0-1000 range is reserved by the CSS Working Group.
//
// TODO(https://crbug.com/978781): Spec a proper number.
kPropertyRule = 1001,
}; };
virtual Type type() const = 0; virtual Type type() const = 0;
......
...@@ -51,6 +51,6 @@ ...@@ -51,6 +51,6 @@
[RuntimeEnabled=CSSViewport] const unsigned short VIEWPORT_RULE = 15; [RuntimeEnabled=CSSViewport] const unsigned short VIEWPORT_RULE = 15;
// CSS Properties and Values Level 1 // CSS Properties and Values Level 1
// TODO(https://crbug.com/978781): Spec a proper number. // https://drafts.css-houdini.org/css-properties-values-api/#extensions-to-css-rule-interface
[RuntimeEnabled=CSSVariables2AtProperty] const unsigned short PROPERTY_RULE = 1001; [RuntimeEnabled=CSSVariables2AtProperty] const unsigned short PROPERTY_RULE = 18;
}; };
...@@ -15,8 +15,8 @@ FAIL CSSPropertyRule interface: attribute name assert_true: The prototype object ...@@ -15,8 +15,8 @@ FAIL CSSPropertyRule interface: attribute name assert_true: The prototype object
FAIL CSSPropertyRule interface: attribute syntax assert_true: The prototype object must have a property "syntax" expected true got false FAIL CSSPropertyRule interface: attribute syntax assert_true: The prototype object must have a property "syntax" expected true got false
FAIL CSSPropertyRule interface: attribute inherits assert_true: The prototype object must have a property "inherits" expected true got false FAIL CSSPropertyRule interface: attribute inherits assert_true: The prototype object must have a property "inherits" expected true got false
FAIL CSSPropertyRule interface: attribute initialValue assert_true: The prototype object must have a property "initialValue" expected true got false FAIL CSSPropertyRule interface: attribute initialValue assert_true: The prototype object must have a property "initialValue" expected true got false
FAIL CSSRule interface: constant PROPERTY_RULE on interface object assert_equals: property has wrong value expected 18 but got 1001 PASS CSSRule interface: constant PROPERTY_RULE on interface object
FAIL CSSRule interface: constant PROPERTY_RULE on interface prototype object assert_equals: property has wrong value expected 18 but got 1001 PASS CSSRule interface: constant PROPERTY_RULE on interface prototype object
PASS CSS namespace: operation escape(CSSOMString) PASS CSS namespace: operation escape(CSSOMString)
PASS CSS namespace: operation registerProperty(PropertyDefinition) PASS CSS namespace: operation registerProperty(PropertyDefinition)
Harness: the test ran to completion. Harness: the test ran to completion.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment