Revert of Migrate IME state update flow (patchset #4 id:100001 of...
Revert of Migrate IME state update flow (patchset #4 id:100001 of https://codereview.chromium.org/2777223004/ ) Reason for revert: This patchset caused a regression crbug.com/709349: 'cut' option disappeared from webview selection pop up. Original issue's description: > Migrate IME state update flow > > Refactored the flow for IME state update so it bypasses CVCImpl > and go straight from RWHVA -> ImeAdapter native -> Java layer. > > Other related changes are: > > ImeAdapter provides EventObserver to reduce the dependency on CVC, > based on the suggestion made in https://goo.gl/pdtQCl. It is used > by an embedder (Chrome) and CVC to deal with IME notification. > This replaces IME state update done through CVC. Only the necessary > info (node editability, password attribute) are passed. > > ImeAdapter.ImeAdapterDelegate is to delegate some work upon IME > events. But it is used by ContentViewCore only, and there is no > clear benefit of having the interface. It was removed for > simplification. All the stuff can be (and are now) handled inside > ImeAdapter. > > BUG=662908,626765,620172 > > Review-Url: https://codereview.chromium.org/2777223004 > Cr-Commit-Position: refs/heads/master@{#462419} > Committed: https://chromium.googlesource.com/chromium/src/+/cc9e77e7d9e05da0f6017f1bdea024f0ce669786 TBR=boliu@chromium.org,tedchoc@chromium.org,jinsukkim@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=662908,626765,620172 Review-Url: https://codereview.chromium.org/2803203003 Cr-Commit-Position: refs/heads/master@{#463053}
Showing
This diff is collapsed.
This diff is collapsed.
Please register or sign in to comment