Commit eeb30d05 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Extend a PDFExtensionTest to check context menu items.

In PDFExtensionTest, there already exists a test case that uses
ContextMenuWaiter to interact with the context menu. Extend the test to
also check the menu items seen by the ContextMenuWaiter. This is a
regression test to make sure context menu items do not go missing by
accident.

Bug: 1126791
Change-Id: I26b60040ae83e88a835a41443adf439c410e54a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430827Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810716}
parent 5fadbe2d
...@@ -30,6 +30,7 @@ ...@@ -30,6 +30,7 @@
#include "base/threading/thread_restrictions.h" #include "base/threading/thread_restrictions.h"
#include "build/branding_buildflags.h" #include "build/branding_buildflags.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/content_settings/host_content_settings_map_factory.h" #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
#include "chrome/browser/extensions/component_loader.h" #include "chrome/browser/extensions/component_loader.h"
#include "chrome/browser/extensions/extension_apitest.h" #include "chrome/browser/extensions/extension_apitest.h"
...@@ -90,6 +91,7 @@ ...@@ -90,6 +91,7 @@
#include "net/test/embedded_test_server/embedded_test_server.h" #include "net/test/embedded_test_server/embedded_test_server.h"
#include "pdf/pdf_features.h" #include "pdf/pdf_features.h"
#include "services/network/public/cpp/features.h" #include "services/network/public/cpp/features.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "third_party/blink/public/common/context_menu_data/media_type.h" #include "third_party/blink/public/common/context_menu_data/media_type.h"
#include "ui/accessibility/ax_action_data.h" #include "ui/accessibility/ax_action_data.h"
#include "ui/accessibility/ax_enum_util.h" #include "ui/accessibility/ax_enum_util.h"
...@@ -2608,6 +2610,19 @@ IN_PROC_BROWSER_TEST_P(PDFExtensionTestWithParam, ...@@ -2608,6 +2610,19 @@ IN_PROC_BROWSER_TEST_P(PDFExtensionTestWithParam,
ui::GestureEventDetails(ui::ET_GESTURE_TAP)); ui::GestureEventDetails(ui::ET_GESTURE_TAP));
ellipsis_button->OnGestureEvent(&tap); ellipsis_button->OnGestureEvent(&tap);
context_menu_observer.WaitForMenuOpenAndClose(); context_menu_observer.WaitForMenuOpenAndClose();
// Verify that the expected context menu items are present.
//
// Note that the assertion below doesn't use exact matching via
// testing::ElementsAre, because some platforms may include unexpected extra
// elements (e.g. an extra separator and IDC=100 has been observed on some Mac
// bots).
EXPECT_THAT(
context_menu_observer.GetCapturedCommandIds(),
testing::IsSupersetOf(
{IDC_CONTENT_CONTEXT_COPY, IDC_CONTENT_CONTEXT_SEARCHWEBFOR,
IDC_PRINT, IDC_CONTENT_CONTEXT_ROTATECW,
IDC_CONTENT_CONTEXT_ROTATECCW, IDC_CONTENT_CONTEXT_INSPECTELEMENT}));
} }
#endif // defined(TOOLKIT_VIEWS) && defined(USE_AURA) #endif // defined(TOOLKIT_VIEWS) && defined(USE_AURA)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment