Turn down NavigationPredictorPreconnectSocketCompletionTime experiment

Remove the logic for the experiment since it does not show any
performance improvement.

Bug: 1130607
Change-Id: Ifaf8ca94bece6fe48aa0c9b7038357b0a563f982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575194
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834484}

chrome/browser/navigation_predictor/navigation_predictor_features.cc

@@ -24,11 +24,6 @@ const base::Feature
         "NavigationPredictorEnablePreconnectOnSameDocumentNavigations",
         base::FEATURE_DISABLED_BY_DEFAULT};
 
-// Used for controlling the navigation predictor based preconnect experiments.
-const base::Feature kNavigationPredictorPreconnectSocketCompletionTime{
-    "NavigationPredictorPreconnectSocketCompletionTime",
-    base::FEATURE_DISABLED_BY_DEFAULT};
-
 const base::Feature kNavigationPredictorRendererWarmup{
     "NavigationPredictorRendererWarmup", base::FEATURE_DISABLED_BY_DEFAULT};
 

chrome/browser/navigation_predictor/navigation_predictor_features.h

@@ -14,7 +14,6 @@ namespace features {
 extern const base::Feature kNavigationPredictorPreconnectHoldback;
 extern const base::Feature
     kNavigationPredictorEnablePreconnectOnSameDocumentNavigations;
-extern const base::Feature kNavigationPredictorPreconnectSocketCompletionTime;
 extern const base::Feature kNavigationPredictorRendererWarmup;
 
 }  // namespace features

chrome/browser/navigation_predictor/navigation_predictor_preconnect_client.cc

@@ -179,10 +179,7 @@ void NavigationPredictorPreconnectClient::MaybePreconnectNow(
 
   // The delay beyond the idle socket timeout that net uses when
   // re-preconnecting. If negative, no retries occur.
-  const base::TimeDelta retry_delay =
-      base::TimeDelta::FromMilliseconds(base::GetFieldTrialParamByFeatureAsInt(
-          features::kNavigationPredictorPreconnectSocketCompletionTime,
-          "preconnect_socket_completion_time_msec", 50));
+  const base::TimeDelta retry_delay = base::TimeDelta::FromMilliseconds(50);
 
   // Set/Reset the timer to fire after the preconnect times out. Add an extra
   // delay to make sure the preconnect has expired if it wasn't used.

chrome/browser/navigation_predictor/search_engine_preconnector.cc

@@ -106,10 +106,7 @@ void SearchEnginePreconnector::PreconnectDSE() {
 
   // The delay beyond the idle socket timeout that net uses when
   // re-preconnecting. If negative, no retries occur.
-  const base::TimeDelta retry_delay =
-      base::TimeDelta::FromMilliseconds(base::GetFieldTrialParamByFeatureAsInt(
-          features::kNavigationPredictorPreconnectSocketCompletionTime,
-          "preconnect_socket_completion_time_msec", 50));
+  const base::TimeDelta retry_delay = base::TimeDelta::FromMilliseconds(50);
 
   // Set/Reset the timer to fire after the preconnect times out. Add an extra
   // delay to make sure the preconnect has expired if it wasn't used.

testing/variations/fieldtrial_testing_config.json

@@ -4614,28 +4614,6 @@
             ]
         }
     ],
-    "NavigationPredictorPreconnectSocketCompletionTime": [
-        {
-            "platforms": [
-                "android",
-                "chromeos",
-                "linux",
-                "mac",
-                "windows"
-            ],
-            "experiments": [
-                {
-                    "name": "Enabled",
-                    "params": {
-                        "preconnect_socket_completion_time_msec": "3000"
-                    },
-                    "enable_features": [
-                        "NavigationPredictorPreconnectSocketCompletionTime"
-                    ]
-                }
-            ]
-        }
-    ],
     "NewUsbBackend": [
         {
             "platforms": [