Commit eee513df authored by John Budorick's avatar John Budorick Committed by Commit Bot

chrome_cleaner: ensure internal targets are reachable from :gn_all.

Bug: 984162, 1004848
Change-Id: Ibb7c47f0188de8e077cd30aa8d68ca61133d2037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904549
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: default avatarJoe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713683}
parent 37c768e9
...@@ -608,7 +608,7 @@ group("gn_all") { ...@@ -608,7 +608,7 @@ group("gn_all") {
if (is_win) { if (is_win) {
deps += [ deps += [
"//base:pe_image_test", "//base:pe_image_test",
"//chrome/chrome_cleaner:chrome_cleaner_unittests", "//chrome/chrome_cleaner",
"//chrome/chrome_elf:chrome_elf_unittests", "//chrome/chrome_elf:chrome_elf_unittests",
"//chrome/chrome_elf:dll_hash_main", "//chrome/chrome_elf:dll_hash_main",
"//chrome/elevation_service:elevation_service_unittests", "//chrome/elevation_service:elevation_service_unittests",
......
...@@ -64,9 +64,6 @@ static_library("other_executable_definitions") { ...@@ -64,9 +64,6 @@ static_library("other_executable_definitions") {
} }
test("chrome_cleaner_unittests") { test("chrome_cleaner_unittests") {
# Make this target findable from the "all" target used by the builders.
visibility += [ "//.:gn_all" ]
sources = [ sources = [
"//chrome/chrome_cleaner/test/test_main.cc", "//chrome/chrome_cleaner/test/test_main.cc",
] ]
...@@ -126,3 +123,23 @@ test("chrome_cleaner_unittests") { ...@@ -126,3 +123,23 @@ test("chrome_cleaner_unittests") {
] ]
} }
} }
group("chrome_cleaner") {
testonly = true
# Make this target findable from the "all" target used by the builders.
visibility += [ "//.:gn_all" ]
deps = [
":chrome_cleaner_unittests",
"//chrome/chrome_cleaner/executables:chrome_cleanup_tool",
"//chrome/chrome_cleaner/executables:software_reporter_tool",
]
if (is_internal_chrome_cleaner_build) {
deps += [
"${chrome_cleaner_internal_root}:build_targets",
"${chrome_cleaner_internal_root}:test_targets",
]
}
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment