Commit eee777fd authored by Nico Weber's avatar Nico Weber

Disable flaky test and run network_service_browser_tests on win-asan.

Disables SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile
which is flaky on several platforms (and fails consistenly on linux/asan).

TBR=lukasza

Bug: 840063
Change-Id: I7ac546dcb8f4a60417e45ca9b7ce20667b31abcb
Reviewed-on: https://chromium-review.googlesource.com/1180709Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584351}
parent ec002be9
...@@ -1182,8 +1182,9 @@ IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest, ...@@ -1182,8 +1182,9 @@ IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest,
} }
// Tests that saving a page from file: URI works. // Tests that saving a page from file: URI works.
// TODO(https://crbug.com/840063): Deflake and reenable.
IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest, IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest,
ObjectElementsViaFile) { DISABLED_ObjectElementsViaFile) {
base::FilePath test_data_dir; base::FilePath test_data_dir;
ASSERT_TRUE(base::PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir)); ASSERT_TRUE(base::PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir));
GURL url(net::FilePathToFileURL( GURL url(net::FilePathToFileURL(
......
...@@ -7548,6 +7548,23 @@ ...@@ -7548,6 +7548,23 @@
}, },
"test": "browser_tests" "test": "browser_tests"
}, },
{
"args": [
"--enable-features=NetworkService",
"--test-launcher-filter-file=../../testing/buildbot/filters/mojo.fyi.network_browser_tests.filter"
],
"name": "network_service_browser_tests",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Windows-10-15063"
}
],
"shards": 15
},
"test": "browser_tests"
},
{ {
"args": [ "args": [
"--enable-features=VizDisplayCompositor" "--enable-features=VizDisplayCompositor"
......
...@@ -824,7 +824,6 @@ ...@@ -824,7 +824,6 @@
# chromium.memory # chromium.memory
'Linux ASan LSan Tests (1)', # No capacity, https://crbug.com/852442 'Linux ASan LSan Tests (1)', # No capacity, https://crbug.com/852442
'Linux TSan Tests', # No capacity, https://crbug.com/852442 'Linux TSan Tests', # No capacity, https://crbug.com/852442
'win-asan', # https://crbug.com/840063
# chromium.win # chromium.win
'Win7 Tests (1)', # For swarming capacity reasons. 'Win7 Tests (1)', # For swarming capacity reasons.
'Win10 Tests x64 (dbg)', # Matches browser_tests. 'Win10 Tests x64 (dbg)', # Matches browser_tests.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment