Commit eef1d9c8 authored by xunjieli's avatar xunjieli Committed by Commit bot

Fix UMA logging for net::BidirectionalStream

The CL fixes the UMA to use suffixes correctly.
See crbug.com/643573 for more info.

BUG=635548,643573

Review-Url: https://codereview.chromium.org/2311433002
Cr-Commit-Position: refs/heads/master@{#416359}
parent 55e10010
...@@ -391,30 +391,30 @@ void BidirectionalStream::UpdateHistograms() { ...@@ -391,30 +391,30 @@ void BidirectionalStream::UpdateHistograms() {
return; return;
} }
if (GetProtocol() == kProtoHTTP2) { if (GetProtocol() == kProtoHTTP2) {
UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.HTTP2.TimeToReadStart", UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.TimeToReadStart.HTTP2",
read_start_time_ - start_time_); read_start_time_ - start_time_);
UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.HTTP2.TimeToReadEnd", UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.TimeToReadEnd.HTTP2",
read_end_time_ - start_time_); read_end_time_ - start_time_);
UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.HTTP2.TimeToSendStart", UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.TimeToSendStart.HTTP2",
send_start_time_ - start_time_); send_start_time_ - start_time_);
UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.HTTP2.TimeToSendEnd", UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.TimeToSendEnd.HTTP2",
send_end_time_ - start_time_); send_end_time_ - start_time_);
UMA_HISTOGRAM_COUNTS("Net.BidirectionalStream.HTTP2.ReceivedBytes", UMA_HISTOGRAM_COUNTS("Net.BidirectionalStream.ReceivedBytes.HTTP2",
stream_impl_->GetTotalReceivedBytes()); stream_impl_->GetTotalReceivedBytes());
UMA_HISTOGRAM_COUNTS("Net.BidirectionalStream.HTTP2.SentBytes", UMA_HISTOGRAM_COUNTS("Net.BidirectionalStream.SentBytes.HTTP2",
stream_impl_->GetTotalSentBytes()); stream_impl_->GetTotalSentBytes());
} else if (GetProtocol() == kProtoQUIC1SPDY3) { } else if (GetProtocol() == kProtoQUIC1SPDY3) {
UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.QUIC.TimeToReadStart", UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.TimeToReadStart.QUIC",
read_start_time_ - start_time_); read_start_time_ - start_time_);
UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.QUIC.TimeToReadEnd", UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.TimeToReadEnd.QUIC",
read_end_time_ - start_time_); read_end_time_ - start_time_);
UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.QUIC.TimeToSendStart", UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.TimeToSendStart.QUIC",
send_start_time_ - start_time_); send_start_time_ - start_time_);
UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.QUIC.TimeToSendEnd", UMA_HISTOGRAM_TIMES("Net.BidirectionalStream.TimeToSendEnd.QUIC",
send_end_time_ - start_time_); send_end_time_ - start_time_);
UMA_HISTOGRAM_COUNTS("Net.BidirectionalStream.QUIC.ReceivedBytes", UMA_HISTOGRAM_COUNTS("Net.BidirectionalStream.ReceivedBytes.QUIC",
stream_impl_->GetTotalReceivedBytes()); stream_impl_->GetTotalReceivedBytes());
UMA_HISTOGRAM_COUNTS("Net.BidirectionalStream.QUIC.SentBytes", UMA_HISTOGRAM_COUNTS("Net.BidirectionalStream.SentBytes.QUIC",
stream_impl_->GetTotalSentBytes()); stream_impl_->GetTotalSentBytes());
} }
} }
......
...@@ -101283,8 +101283,7 @@ To add a new entry, add it with any value and run test to compute valid value. ...@@ -101283,8 +101283,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Navigation.TimeToURLJobStart"/> <affected-histogram name="Navigation.TimeToURLJobStart"/>
</histogram_suffixes> </histogram_suffixes>
<histogram_suffixes name="Net.BidirectionalStreamExperiment" separator="." <histogram_suffixes name="Net.BidirectionalStreamExperiment" separator=".">
ordering="prefix">
<owner>xunjieli@chromium.org</owner> <owner>xunjieli@chromium.org</owner>
<suffix name="QUIC" label="Bidirectional streams that use QUIC protocol"/> <suffix name="QUIC" label="Bidirectional streams that use QUIC protocol"/>
<suffix name="HTTP2" label="Bidirectional stream that use HTTP2 protocol"/> <suffix name="HTTP2" label="Bidirectional stream that use HTTP2 protocol"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment